Commit graph

70 commits

Author SHA1 Message Date
Abdelrahman AL MAROUK
259fc3265e [StructureFromMotion] add option to enable/disable track merging based on duplicate features 2023-10-12 15:41:57 +02:00
Fabien Castan
5aff0ce5cd [nodes] StructureFromMotion: update label and description for the alignment option 2023-09-22 14:00:27 +02:00
Fabien SERVANT
6f44e705fb option to Align sfm at the end 2023-09-21 10:32:50 +02:00
Candice Bentéjac
fd1292ad00 [nodes] StructureFromMotion: Add new logIntermediateSteps parameter
If enabled, the current state of the scene will be dumped as an SfMData
file every 3 resections. Before this option was added, the intermediate
steps were always dumped.
2023-09-08 19:30:15 +02:00
Candice Bentéjac
c498f48e1e [nodes] S-T: Harmonize and improve labels and descriptions
Use CamelCase for all labels, always end descriptions with periods, and
replace the mixed use of single and double quotes with double quotes
only.
2023-06-16 10:32:01 +02:00
Loïc Vital
e6d58de546 [nodes] SfM: extend maxImagesPerGroup range to 0 2023-06-15 12:02:52 +02:00
Loïc Vital
9194b13e1f [nodes] SfM: extend nbFirstUnstableCamera range to 0 2023-06-15 11:29:55 +02:00
Loïc Vital
5baac5307d [nodes] StructureFromMotion: allow negative bundleAdjustmentMaxOutliers to disable BA iterations 2023-05-17 16:35:06 +02:00
Loïc Vital
6b8b373af8 [nodes] StructureFromMotion: new bundleAdjustmentMaxOutliers attribute 2023-05-17 14:58:22 +02:00
Candice Bentéjac
70170c0972 [nodes] StructureFromMotion: Add new inputs parameters
Add two new input parameters, `nbFirstUnstableCameras` which sets the
number of cameras for which a bundle adjustment is performed every time
a camera is added, and `maxImagesPerGroup` which sets the maximum number
of cameras that can be added before the bundle adjustment has to be
performed again.

By default, the bundle adjustment will be performed every time one of
the first 30 cameras is added, as computations are not too expensive
while there are few cameras. Past that number, the bundle adjustment will
only be performed when up to 30 cameras have been added.

The node's version is updated accordingly.
2023-04-13 14:42:06 +02:00
Candice Bentéjac
b42e7cbd87 [nodes] StructureFromMotion: Update description of "initialPair" files
"initialPairA" and "initialPairB" can either be the filename of the image
(without the path), the whole path of the image, or its view ID.
2023-03-15 16:19:44 +01:00
fabien servant
ae0ca71c1c [nodes] replace CommandLineNode with AVCommandLineNode for alicevision nodes 2022-12-06 15:07:01 +01:00
Loïc Vital
a5fbbe7d82 [node] output labels renaming without 'Output' prefix 2022-10-19 09:50:21 +01:00
Candice Bentéjac
e7290313bf [nodes] Align FloatParams' and IntParams' ranges with their params' type 2022-09-28 10:41:39 +02:00
Grégoire De Lillo
a2c255c917 [nodes] StructureFromMotion: add option computeStructureColor 2022-03-01 01:36:59 +01:00
luz paz
f4dcf6557f Fix various typos in the source code
## Description
Fix various typos in the source code. This includes user facing code, documentation, and source comments. This PR has not been tested.
Closes #1605
2022-01-22 07:39:05 -05:00
elektrokokke
f1331c6a15
Integration of AprilTag library according to issue #1179 and AliceVision pull request #950 (#1180)
* According to Meshroom issue #1179 (https://github.com/alicevision/meshroom/issues/1179),
add the describer type "tag16h5" to the following modules:
- ConvertSfmFormat (e.g., to be able to export the 3D AprilTag positions in a human-readable format as .sfm,
or to see only the AprilTag marker positions in the 3D view via .abc)
- FeatureExtraction (to be able to detect AprilTag markers from the tag16h5 family)
- FeatureMatching (to be able to match AprilTag markers)
- SfmTransform (to be able to use AprilTag markers, e.g., for the auto_from_markers transform)
- StructureFromMotion (to be able to compute the 3D positions of AprilTag markers)

* Added a new input to sfmTransform: markerDistances, which is a pair of marker IDs associated with the distance between them.
Added a corresponding new transform: from_marker_distances, which scales the model according to the given distances between pairs of markers.
Added another transform: auto_from_markers, which uses the existing markers parameter (ignoring their x,y,z positions) and applies the auto_from_... function only based on these given markers. The latter transform can, e.g., be used to align a set of markers with the ground plane.

* Revert "Added a new input to sfmTransform: markerDistances, which is a pair of marker IDs associated with the distance between them."

This reverts commit ed87c68f39.

Co-authored-by: jarne <jarne@ieee.org>
Co-authored-by: Fabien Castan <fabcastan@gmail.com>
2021-07-23 16:36:02 +02:00
Fabien Castan
f26cbda2c0 [nodes] StructureFromMotion: expose new parameters minNbCamerasToRefinePrincipalPoint and rigMinNbCamerasForCalibration 2021-07-21 11:03:35 +02:00
Fabien Castan
e330201077 [nodes] sfm: change default value for observationConstraint to scale 2021-04-16 10:44:40 +02:00
Fabien Castan
7ee28b23ff [nodes] use dspsift instead of sift by default 2021-04-16 10:44:39 +02:00
ChemicalXandco
e18f815af9 [nodes] add node categories 2021-02-14 17:03:42 +00:00
Fabien Castan
1102ce84e0 Merge branch 'develop' of github.com:alicevision/meshroom into dev/nodesAndTaskManager
Conflicts:
	meshroom/core/graph.py
	meshroom/ui/qml/main.qml
2020-12-01 20:02:43 +01:00
Fabien Castan
dfaa19e5e2 [nodes] add feature type: dsp-sift 2020-11-20 18:00:22 +01:00
Julien-Haudegond
79e1c69d5d Merge remote-tracking branch 'origin/develop' into dev/nodesAndTaskManager 2020-08-24 15:19:31 +02:00
Fabien Castan
368c7a81c1 [nodes] StructureFromMotion: change default value for filterTrackForks 2020-08-12 16:25:07 +02:00
Fabien Castan
bab908d2eb Merge branch 'develop' into dev/nodesAndTaskManager 2020-07-30 10:56:19 +02:00
Fabien Castan
91f53341bc warning fixes 2020-07-16 11:04:43 +02:00
Fabien Castan
21fa9167ae [nodes] SfMTransform, SfMTransfer, SfMAlignment expose the same output params than the StructureFromMotion node 2020-06-29 13:59:53 +02:00
Fabien Castan
49c03bc239 [ui] Reconstruction: the active sfm node can be a StructureFromMotion or a PanoramaEstimation node 2020-06-25 01:10:25 +02:00
Fabien Castan
2f17e9aa80 Merge remote-tracking branch 'origin/develop' into dev/panoramaFisheye 2020-03-26 13:56:51 +01:00
Fabien Castan
64a4c9426a [nodes] add some nodes documentation 2020-03-26 11:20:44 +01:00
Theo
d6c0c595b9 [nodes] StructureFromMotion: Add new observation constraint mode 2020-03-19 15:04:16 +01:00
Theo
b075945266 [nodes] StructureFromMotion: Add option minNumberOfMatches 2020-01-29 10:32:59 +01:00
Theo
bc877616e2 [nodes] StructureFromMotion: Add option filterTrackForks 2020-01-29 10:32:59 +01:00
Yann Lanthony
ac149e1e51 [nodes][aliceVision] use user-friendly atribute labels 2020-01-24 12:00:13 +01:00
Yann Lanthony
c7a55e56b7
[reconstruction] retrieve and expose solved intrinsics
* [nodes] SfM: make more generic method to get SfM results and return solved intrinsics in addition to views and poses
* [reconstruction] store and expose solved intrinsics by viewpoints
2019-09-10 18:23:35 +02:00
Yann Lanthony
a82b0d0627
Merge pull request #375 from alicevision/dev_estimatorParams
[nodes] expose estimator parameters on sfm and features matching
2019-01-28 10:55:36 +01:00
Yann Lanthony
0c9c2b2424
Merge pull request #329 from alicevision/devSfmIntrinsicsInput
[CLI] Add possibility to run pipeline from a .sfm file
2019-01-28 10:54:37 +01:00
Fabien Castan
349de9a3a6 [nodes] expose estimator parameters on sfm and features matching 2019-01-28 10:52:48 +01:00
Fabien Castan
d924499470 [nodes] sfm: rename param refineIntrinsics into lockAllIntrinsics 2019-01-28 10:46:19 +01:00
Yann Lanthony
168b573e36 [nodes][aliceVision] mark advanced parameters 2018-12-20 11:17:23 +01:00
Simone Gasparini
e1c5a6c5e7
[nodes] exposed refineIntrinsics param to lock the camera intrinsics
for all cameras
2018-12-19 18:02:10 +01:00
Grégoire De Lillo
3429f0cce2 [nodes] StructureFromMotion Rename param useRigsCalibration to useRigConstraint 2018-12-13 11:44:55 +01:00
Grégoire De Lillo
465d1fb6c8 [nodes] StructureFromMotion Add useRigsCalibration option
StructureFromMotion node is now 2.0
2018-10-01 15:37:21 +02:00
Yann Lanthony
2a410d07ea [nodes][aliceVision] add initial version on nodes 2018-07-19 13:50:45 +02:00
Yann Lanthony
346277629a [nodes] use 'desc.Node.internalFolder' in outputs values
* avoid duplicating the same string everywhere
* don't override 'internalFolder' with the same value default value in subclasses
2018-07-19 13:50:45 +02:00
Grégoire De Lillo
d463195f8c [nodes] StructureFromMotion add lockScenePreviouslyReconstructed option 2018-07-10 11:59:01 +02:00
Grégoire De Lillo
784ebefe17 [nodes] StructureFromMotion Add options 2018-06-21 16:34:57 +02:00
Grégoire De Lillo
50f01c4222 [nodes] Use lower case for imageDescriber type and preset 2018-06-21 16:34:57 +02:00
Grégoire De Lillo
236a82ece8 [nodes] Add support for multiple features & matches folders 2018-06-21 16:34:57 +02:00