Commit graph

2945 commits

Author SHA1 Message Date
Fabien Servant
a00a36a5ed [sfmTransform] add auto mode 2023-04-04 17:03:57 +02:00
Fabien Castan
6f9544c1a5
Merge pull request #1948 from alicevision/dev/updateAboutDialog
Display the changelog in the "About" dialog and update copyrights
2023-03-27 13:57:04 +02:00
Candice Bentéjac
420b9c43ff [docs] Update copyrights for the documentation 2023-03-24 16:31:16 +01:00
Candice Bentéjac
91bdddfaf8 [ui] Add Meshroom's changelog model
The changelog is added as a model. Although it is meant to be displayed
with the licenses for Meshroom and AliceVision, the changelog model is
provided apart from the licenses' and then concatenated with it so they
are displayed together.
2023-03-24 16:23:13 +01:00
Candice Bentéjac
7a4ebc8751 [ui] Update copyrights for AliceVision contributors 2023-03-24 12:36:23 +01:00
Fabien Castan
10d2073244
Merge pull request #1941 from alicevision/fix/blockedDragDrop
[ui] ImageGallery: Allow image drop if the active group is not computing
2023-03-21 17:56:41 +01:00
Fabien Castan
c062160494
Merge pull request #1942 from alicevision/fix/submitPopUp
[ui] Fix conditions on which the prompt asking the user to save a project before submitting it to the render farm relies
2023-03-21 17:54:10 +01:00
Candice Bentéjac
7488ee2f7e [ui] ImageGallery: Allow image drop if the active group is not computing
The Image Gallery should only switch to read-only if the currently active
group is being computed. The behaviour prior to this commit was to lock it
as soon as any node in the entire graph was being computed, even if it did
not involve the active CameraInit node.
2023-03-21 12:47:46 +01:00
Candice Bentéjac
9570437b7f [ui] Fix "canSubmit" which relied on erroneous conditions
Remove the "canStartComputation" condition which was not used anywhere
else and was not up-to-date: since it needed more than one image and no
ongoing computations to be "True", attempting to submit several branches
of a graph would always cause it to be "False", which in turn led the
"canSubmit" condition to be "False" (causing the pop-up requesting to
save the file to appear), even though the submission should have been
possible.

The submission should be possible whenever submitters are available and
the project file has been saved.
2023-03-20 16:18:48 +01:00
Fabien Castan
ba0541c791
Merge pull request #1934 from alicevision/fix/intrinsicsTmpCamInit
[ui] Image Gallery: Fix the display of the intrinsics table with temporary CameraInit nodes
2023-03-18 14:50:37 +01:00
Fabien Castan
9d269ba6fa
Merge pull request #1936 from alicevision/dev/sfmSetPair
Image Gallery: Add a menu to set the StructureFromMotion initial pair from the gallery
2023-03-18 14:46:47 +01:00
Fabien Castan
736d069a5d
Merge pull request #1933 from alicevision/dev/texturingColorSpace
Texturing Color Space
2023-03-17 13:27:18 +01:00
Fabien Castan
200ab852c6
[nodes] Texturing: minor update to outputColorSpace param 2023-03-17 12:11:02 +01:00
Fabien Castan
380726e00a
Merge pull request #1935 from alicevision/mug/split360Update
[nodes] Split360Images: update attributes to software version 2.0
2023-03-15 18:41:10 +01:00
Candice Bentéjac
790ede0b89 [ui] ImageGallery: Add an option in the menu to set the SfM initial pair
Add a "SfM: Define Initial Pair" sub-menu in the Image Gallery menu that is
only enabled if the currently active group contains a StructureFromMotion
node. Clicking "A" or "B" will automatically set the selected image's view
ID as a part of the initial pair.
2023-03-15 16:19:45 +01:00
Candice Bentéjac
b42e7cbd87 [nodes] StructureFromMotion: Update description of "initialPair" files
"initialPairA" and "initialPairB" can either be the filename of the image
(without the path), the whole path of the image, or its view ID.
2023-03-15 16:19:44 +01:00
Loïc Vital
eb03516be2 [nodes] Split360Images: update attributes to software version 2.0 2023-03-15 12:06:41 +01:00
Candice Bentéjac
21500bec96 [ui] ImageGallery: Fix QML syntax warnings 2023-03-15 10:55:26 +01:00
Candice Bentéjac
2e31ecaea7 [ui] ImageGallery: Harmonize functions and indentation 2023-03-15 10:36:16 +01:00
Candice Bentéjac
59be396244 [ui] Prevent editing the intrinsics of temporary CameraInit nodes
As the temporary CameraInit nodes are not really part of the graph, their
attributes cannot be edited. By default, the intrinsics can be edited for
any CameraInit node from the intrinsics table.

For temporary CameraInit nodes, we want the intrinsics to be displayed in
read-only mode to ensure that the user cannot attempt to edit them, which
would cause errors.

Upon its creation, the temporary CameraInit node is locked (as if it were
computed), and the intrinsics table's component are updated to be displayed
as read-only if the CameraInit node is locked.
2023-03-15 10:00:19 +01:00
Candice Bentéjac
ac592f4cb2 [ui] ImageGallery: Re-parse intrinsics as soon as they are updated
When setting a temporary CameraInit node, the intrinsics of the actual
CameraInit node are used, meaning that the temporary CameraInit has all
the intrinsics information we need to fill the intrinsics table.

However, when a temporary CameraInit node is set, the parsing of the
intrinsics and the model update are not performed. If the active CameraInit
group does not change, this is not directly visible as the table keeps on
displaying the intrinsics from the actual CameraInit node.

If the active group changes, we attempt to fill the table with the
intrinsics of the temporary CameraInit node, which is being re-set for the
active group. The intrinsics are thus not available, leading to an empty
table, and the parsing is never retriggered once the temporary CameraInit
has been fully set.

Instead of re-parsing the intrinsics when the CameraInitIndex is updated,
the parsing is triggered when the intrinsics are updated, since this
ensures they will be available and its covers all the cases we could
be facing.
2023-03-15 10:00:08 +01:00
Candice Bentéjac
3e8e568bba [ui] ImageGallery: Update columns' width for the intrinsics table 2023-03-14 18:36:05 +01:00
Fabien Castan
a67f77de68
Merge pull request #1931 from alicevision/fix/updateViewer2D
[ui] Correctly update the Viewer 2D when there are temporary CameraInit nodes
2023-03-14 17:43:39 +01:00
Fabien Castan
312049691e
Merge pull request #1930 from alicevision/fix/imageProcessingLCP
[nodes] ImageProcessing: Add and hide the fringing correction in the LCP
2023-03-14 17:27:19 +01:00
Fabien Castan
9ccece2bec
Merge pull request #1880 from alicevision/dev/cleanKeyframeSelection
[nodes] KeyframeSelection: Rework the node and add parameters for new selection methods
2023-03-14 17:26:46 +01:00
demoulinv
008d901a13 [Node] Texturing: Replace processcolorspaceName with workingcolorSpace and add outputColorSpace 2023-03-14 14:59:15 +01:00
Fabien Castan
eb6d65f938
Merge pull request #1915 from alicevision/mug/fix/metadataViewer2D
[ui] Viewer2D: fix displayed metadata
2023-03-13 19:06:47 +01:00
Candice Bentéjac
c1fdab86fc [nodes] ImageProcessing: Add and hide the fringing correction in the LCP
Add a parameter for the correction of chromatic aberrations in the LCP
group but disable it. It will need to be re-enabled later on, when there
will be a full support of the chromatic aberration correction.
2023-03-13 18:20:20 +01:00
Candice Bentéjac
5e61a1da5a [ui] ImageGallery: Force index to -1 before setting it if there's a tempCameraInit
When there is a temporary CameraInit, it means that either the "Visualize
HDR images" or "Preprocessed images" options are enabled.

If several CameraInit groups are available, and if the currently selected
image in the GridView is the first one (index = 0), there is a possibility,
depending on the input images, that the first images in two different
groups are not identical but have the same view ID. If that happens, there
will be no update of the Viewer2D, as the selectedViewId property will not
have been modified.

By setting the selectedViewId property to -1 when there is a temporary
CameraInit and the current index in the GridView is 0, we trigger an
update of the viewer even when there is no apparent change in the view ID.
2023-03-13 15:57:24 +01:00
Candice Bentéjac
4001c4fc3e [ui] Update active CameraInit's index when loading a LdrToHdrMerge node
If a LdrToHdrMerge node does not belong to the active group but is set as
active (by loading it with a double-click), if it is connected to another
CameraInit node, and if the "Visualize HDR images" has been enabled, then
the active group should be updated to that other CameraInit node.

By updating the active CameraInit's index, not only will the Image Gallery
display the newly selected LdrToHdrMerge thumbnails (already working prior
to this commit), but the Viewer2D will also be updated to reflect the
Gallery's selected thumbnail correctly. Information provided by the Gallery
will also reflect its content, as the active group will correspond to the
shown images, which was not the case before.
2023-03-13 15:57:23 +01:00
Fabien Castan
4b6bd34268
Merge pull request #1929 from alicevision/fix/updateAfterClear
[ui] Clear Images: Request a graph update after resetting the viewpoints and intrinsics
2023-03-13 14:30:36 +01:00
Fabien Castan
fe5ecc8f8f
Merge pull request #1771 from alicevision/dev/LCPManagement
Add support for Lens Camera Profiles (LCP)
2023-03-13 14:29:19 +01:00
Fabien Castan
c7022ff343 [nodes] CameraInit: update advanced mode for group and field of view params 2023-03-13 14:19:40 +01:00
Fabien Castan
2ba6f47a01 [nodes] CameraInit: update advanced modes for initModes and lens search mode 2023-03-13 14:19:05 +01:00
Fabien Castan
95218570f1 [ui] ImageGallery: fix variable name distortionInitializationMode 2023-03-13 14:00:58 +01:00
mugulmd
571ef22b9d [ui] Viewer2D: handle special case of 8bit viewer for metadata 2023-03-13 04:41:42 -07:00
mugulmd
748512f38a [ui] separate viewpoint metadata from image metadata 2023-03-13 04:02:10 -07:00
Candice Bentéjac
1227704b5a [nodes] KeyframeSelection: Update "pxDisplacement" default value to 10% 2023-03-13 11:53:17 +01:00
demoulinv
9969b76cd3 [cameraInit] rename parameter distoInitializationMode into distortionInitializationMode 2023-03-13 10:26:11 +01:00
Candice Bentéjac
8f6f3eec08 [ui] Clear Images: Request graph update after resetting the attributes 2023-03-13 10:08:28 +01:00
Fabien Castan
d333b539cc
Merge pull request #1928 from alicevision/dev/ImgProcessingMenuAdjust
Update highlight mode description in imageProcessing node
2023-03-10 16:56:04 +01:00
demoulinv
f0fc3fd08c [imageProcessing node] Update highlight mode description. 2023-03-10 16:44:11 +01:00
Fabien Castan
6421c03a31
Merge pull request #1927 from alicevision/fix/submitPopUp
[ui] Prompt a warning dialog when attempting to submit an unsaved project
2023-03-10 11:14:21 +01:00
Loïc Vital
14381fb42b [ui] display distoInitMode in image gallery tooltip 2023-03-10 07:58:45 +01:00
demoulinv
811d33eb89 [cameraInit] Add initDistoMode info in intrinsics. 2023-03-10 07:58:44 +01:00
Fabien Castan
b4fa258f4e [nodes] CameraInit: minor update to LCP labels and descriptions 2023-03-10 07:58:43 +01:00
demoulinv
e3231b4f84 [imageProcessing]
Do not expose Chromatic aberration as possible lens correction.
2023-03-10 07:58:43 +01:00
demoulinv
57dfbadb91 [cameraInit] remove enableAutomaticLcpSearch param and add lcp estimation mode 2023-03-10 07:58:42 +01:00
demoulinv
fb34e11b0a [cameraInit] rename parameter for allowing lcp search ignoring camera model 2023-03-10 07:58:41 +01:00
demoulinv
62e21544cf Add required parameters in CameraInit.py and ImageProcessing.py for LCP management and application. 2023-03-10 07:58:40 +01:00