3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-06-27 06:58:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix tests

Browse source
This commit is contained in:
Caleb Doxsey 2022-11-10 14:24:49 -07:00
parent d6dbf86b2d
commit ab8f16e71a
3 changed files with 0 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
authenticate/authenticate_test.go
View file

@ -32,8 +32,6 @@ func TestOptions_Validate(t *testing.T) {
emptyClientID.ClientID = "" emptyClientID.ClientID = ""
emptyClientSecret := newTestOptions(t) emptyClientSecret := newTestOptions(t)
emptyClientSecret.ClientSecret = "" emptyClientSecret.ClientSecret = ""
emptyCookieSecret := newTestOptions(t)
emptyCookieSecret.CookieSecret = ""
invalidCookieSecret := newTestOptions(t) invalidCookieSecret := newTestOptions(t)
invalidCookieSecret.CookieSecret = "OromP1gurwGWjQPYb1nNgSxtbVB5NnLzX6z5WOKr0Yw^" invalidCookieSecret.CookieSecret = "OromP1gurwGWjQPYb1nNgSxtbVB5NnLzX6z5WOKr0Yw^"
shortCookieLength := newTestOptions(t) shortCookieLength := newTestOptions(t)
@ -53,7 +51,6 @@ func TestOptions_Validate(t *testing.T) {
}{ }{
{"minimum options", good, false}, {"minimum options", good, false},
{"nil options", &config.Options{}, true}, {"nil options", &config.Options{}, true},
{"no cookie secret", emptyCookieSecret, true},
{"invalid cookie secret", invalidCookieSecret, true}, {"invalid cookie secret", invalidCookieSecret, true},
{"short cookie secret", shortCookieLength, true}, {"short cookie secret", shortCookieLength, true},
{"no shared secret", badSharedKey, true}, {"no shared secret", badSharedKey, true},

6
config/options_test.go
View file

@ -53,11 +53,6 @@ func Test_Validate(t *testing.T) {
badSignoutRedirectURL := testOptions() badSignoutRedirectURL := testOptions()
badSignoutRedirectURL.SignOutRedirectURLString = "--" badSignoutRedirectURL.SignOutRedirectURLString = "--"
missingSharedSecretWithPersistence := testOptions()
missingSharedSecretWithPersistence.SharedKey = ""
missingSharedSecretWithPersistence.DataBrokerStorageType = StorageRedisName
missingSharedSecretWithPersistence.DataBrokerStorageConnectionString = "redis://somehost:6379"
tests := []struct { tests := []struct {
name string name string
testOpts *Options testOpts *Options
@ -71,7 +66,6 @@ func Test_Validate(t *testing.T) {
{"invalid databroker storage type", invalidStorageType, true}, {"invalid databroker storage type", invalidStorageType, true},
{"missing databroker storage dsn", missingStorageDSN, true}, {"missing databroker storage dsn", missingStorageDSN, true},
{"invalid signout redirect url", badSignoutRedirectURL, true}, {"invalid signout redirect url", badSignoutRedirectURL, true},
{"no shared key with databroker persistence", missingSharedSecretWithPersistence, true},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {

3
proxy/proxy_test.go
View file

@ -41,8 +41,6 @@ func TestOptions_Validate(t *testing.T) {
badAuthURL.AuthenticateURLString = "BAD_URL" badAuthURL.AuthenticateURLString = "BAD_URL"
authenticateBadScheme := testOptions(t) authenticateBadScheme := testOptions(t)
authenticateBadScheme.AuthenticateURLString = "authenticate.corp.beyondperimeter.com" authenticateBadScheme.AuthenticateURLString = "authenticate.corp.beyondperimeter.com"
emptyCookieSecret := testOptions(t)
emptyCookieSecret.CookieSecret = ""
invalidCookieSecret := testOptions(t) invalidCookieSecret := testOptions(t)
invalidCookieSecret.CookieSecret = "OromP1gurwGWjQPYb1nNgSxtbVB5NnLzX6z5WOKr0Yw^" invalidCookieSecret.CookieSecret = "OromP1gurwGWjQPYb1nNgSxtbVB5NnLzX6z5WOKr0Yw^"
shortCookieLength := testOptions(t) shortCookieLength := testOptions(t)
@ -62,7 +60,6 @@ func TestOptions_Validate(t *testing.T) {
}{ }{
{"good - minimum options", good, false}, {"good - minimum options", good, false},
{"nil options", &config.Options{}, true}, {"nil options", &config.Options{}, true},
{"no cookie secret", emptyCookieSecret, true},
{"invalid cookie secret", invalidCookieSecret, true}, {"invalid cookie secret", invalidCookieSecret, true},
{"short cookie secret", shortCookieLength, true}, {"short cookie secret", shortCookieLength, true},
{"no shared secret", badSharedKey, true}, {"no shared secret", badSharedKey, true},