diff --git a/authenticate/authenticate_test.go b/authenticate/authenticate_test.go index 255d6725a..124e8c2a4 100644 --- a/authenticate/authenticate_test.go +++ b/authenticate/authenticate_test.go @@ -32,8 +32,6 @@ func TestOptions_Validate(t *testing.T) { emptyClientID.ClientID = "" emptyClientSecret := newTestOptions(t) emptyClientSecret.ClientSecret = "" - emptyCookieSecret := newTestOptions(t) - emptyCookieSecret.CookieSecret = "" invalidCookieSecret := newTestOptions(t) invalidCookieSecret.CookieSecret = "OromP1gurwGWjQPYb1nNgSxtbVB5NnLzX6z5WOKr0Yw^" shortCookieLength := newTestOptions(t) @@ -53,7 +51,6 @@ func TestOptions_Validate(t *testing.T) { }{ {"minimum options", good, false}, {"nil options", &config.Options{}, true}, - {"no cookie secret", emptyCookieSecret, true}, {"invalid cookie secret", invalidCookieSecret, true}, {"short cookie secret", shortCookieLength, true}, {"no shared secret", badSharedKey, true}, diff --git a/config/options_test.go b/config/options_test.go index 413c29536..2397d562f 100644 --- a/config/options_test.go +++ b/config/options_test.go @@ -53,11 +53,6 @@ func Test_Validate(t *testing.T) { badSignoutRedirectURL := testOptions() badSignoutRedirectURL.SignOutRedirectURLString = "--" - missingSharedSecretWithPersistence := testOptions() - missingSharedSecretWithPersistence.SharedKey = "" - missingSharedSecretWithPersistence.DataBrokerStorageType = StorageRedisName - missingSharedSecretWithPersistence.DataBrokerStorageConnectionString = "redis://somehost:6379" - tests := []struct { name string testOpts *Options @@ -71,7 +66,6 @@ func Test_Validate(t *testing.T) { {"invalid databroker storage type", invalidStorageType, true}, {"missing databroker storage dsn", missingStorageDSN, true}, {"invalid signout redirect url", badSignoutRedirectURL, true}, - {"no shared key with databroker persistence", missingSharedSecretWithPersistence, true}, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { diff --git a/proxy/proxy_test.go b/proxy/proxy_test.go index 44d3c0a11..8ec634442 100644 --- a/proxy/proxy_test.go +++ b/proxy/proxy_test.go @@ -41,8 +41,6 @@ func TestOptions_Validate(t *testing.T) { badAuthURL.AuthenticateURLString = "BAD_URL" authenticateBadScheme := testOptions(t) authenticateBadScheme.AuthenticateURLString = "authenticate.corp.beyondperimeter.com" - emptyCookieSecret := testOptions(t) - emptyCookieSecret.CookieSecret = "" invalidCookieSecret := testOptions(t) invalidCookieSecret.CookieSecret = "OromP1gurwGWjQPYb1nNgSxtbVB5NnLzX6z5WOKr0Yw^" shortCookieLength := testOptions(t) @@ -62,7 +60,6 @@ func TestOptions_Validate(t *testing.T) { }{ {"good - minimum options", good, false}, {"nil options", &config.Options{}, true}, - {"no cookie secret", emptyCookieSecret, true}, {"invalid cookie secret", invalidCookieSecret, true}, {"short cookie secret", shortCookieLength, true}, {"no shared secret", badSharedKey, true},