fix(theme-common): useLocationChange fire un-necessarily twice (#6070)

This commit is contained in:
Sébastien Lorber 2021-12-08 16:38:34 +01:00 committed by GitHub
parent 3394f7e91f
commit f5a404b877
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -25,9 +25,11 @@ export function useLocationChange(onLocationChange: OnLocationChange): void {
const onLocationChangeDynamic = useDynamicCallback(onLocationChange); const onLocationChangeDynamic = useDynamicCallback(onLocationChange);
useEffect(() => { useEffect(() => {
onLocationChangeDynamic({ if (location !== previousLocation) {
location, onLocationChangeDynamic({
previousLocation, location,
}); previousLocation,
});
}
}, [onLocationChangeDynamic, location, previousLocation]); }, [onLocationChangeDynamic, location, previousLocation]);
} }