From f5a404b8772ad460adfa015e036797a286ffeb50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Lorber?= Date: Wed, 8 Dec 2021 16:38:34 +0100 Subject: [PATCH] fix(theme-common): useLocationChange fire un-necessarily twice (#6070) --- .../src/utils/useLocationChange.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/docusaurus-theme-common/src/utils/useLocationChange.ts b/packages/docusaurus-theme-common/src/utils/useLocationChange.ts index 6be0d3000a..0773054390 100644 --- a/packages/docusaurus-theme-common/src/utils/useLocationChange.ts +++ b/packages/docusaurus-theme-common/src/utils/useLocationChange.ts @@ -25,9 +25,11 @@ export function useLocationChange(onLocationChange: OnLocationChange): void { const onLocationChangeDynamic = useDynamicCallback(onLocationChange); useEffect(() => { - onLocationChangeDynamic({ - location, - previousLocation, - }); + if (location !== previousLocation) { + onLocationChangeDynamic({ + location, + previousLocation, + }); + } }, [onLocationChangeDynamic, location, previousLocation]); }