Commit graph

40 commits

Author SHA1 Message Date
luz paz
f4dcf6557f Fix various typos in the source code
## Description
Fix various typos in the source code. This includes user facing code, documentation, and source comments. This PR has not been tested.
Closes #1605
2022-01-22 07:39:05 -05:00
elektrokokke
f1331c6a15
Integration of AprilTag library according to issue #1179 and AliceVision pull request #950 (#1180)
* According to Meshroom issue #1179 (https://github.com/alicevision/meshroom/issues/1179),
add the describer type "tag16h5" to the following modules:
- ConvertSfmFormat (e.g., to be able to export the 3D AprilTag positions in a human-readable format as .sfm,
or to see only the AprilTag marker positions in the 3D view via .abc)
- FeatureExtraction (to be able to detect AprilTag markers from the tag16h5 family)
- FeatureMatching (to be able to match AprilTag markers)
- SfmTransform (to be able to use AprilTag markers, e.g., for the auto_from_markers transform)
- StructureFromMotion (to be able to compute the 3D positions of AprilTag markers)

* Added a new input to sfmTransform: markerDistances, which is a pair of marker IDs associated with the distance between them.
Added a corresponding new transform: from_marker_distances, which scales the model according to the given distances between pairs of markers.
Added another transform: auto_from_markers, which uses the existing markers parameter (ignoring their x,y,z positions) and applies the auto_from_... function only based on these given markers. The latter transform can, e.g., be used to align a set of markers with the ground plane.

* Revert "Added a new input to sfmTransform: markerDistances, which is a pair of marker IDs associated with the distance between them."

This reverts commit ed87c68f39.

Co-authored-by: jarne <jarne@ieee.org>
Co-authored-by: Fabien Castan <fabcastan@gmail.com>
2021-07-23 16:36:02 +02:00
Fabien Castan
7ee28b23ff [nodes] use dspsift instead of sift by default 2021-04-16 10:44:39 +02:00
Fabien Castan
340ab2ec51
Merge pull request #1276 from alicevision/dev/crossMatching
[nodes] featureMatching add cross verification
2021-02-19 11:53:37 +01:00
ChemicalXandco
e18f815af9 [nodes] add node categories 2021-02-14 17:03:42 +00:00
Fabien Servant
ed794b7f04 [nodes] featureMatching add cross verification 2021-02-13 09:07:44 +01:00
Fabien Castan
1102ce84e0 Merge branch 'develop' of github.com:alicevision/meshroom into dev/nodesAndTaskManager
Conflicts:
	meshroom/core/graph.py
	meshroom/ui/qml/main.qml
2020-12-01 20:02:43 +01:00
Fabien Castan
dfaa19e5e2 [nodes] add feature type: dsp-sift 2020-11-20 18:00:22 +01:00
Fabien Castan
bab908d2eb Merge branch 'develop' into dev/nodesAndTaskManager 2020-07-30 10:56:19 +02:00
Fabien Castan
451f5d65c0 Merge branch 'develop' of https://github.com/alicevision/meshroom into dev/panoramaFisheye
Conflicts:
	meshroom/ui/app.py
2020-06-22 17:04:24 +02:00
Simone Gasparini
fe1bd53993
Merge pull request #931 from alicevision/dev_f10
[nodes] `FeatureMatching` Add `fundamental_with_distortion` option
2020-06-08 15:00:47 +02:00
Fabien Castan
64a4c9426a [nodes] add some nodes documentation 2020-03-26 11:20:44 +01:00
Theo
c9d69fdc75 [nodes] FeatureMatching : Add options knownCameraPoses 2020-01-29 10:32:58 +01:00
Yann Lanthony
ac149e1e51 [nodes][aliceVision] use user-friendly atribute labels 2020-01-24 12:00:13 +01:00
Grégoire De Lillo
a41a4e1fdb [nodes] FeatureMatching Add fundamental_with_distortion option 2019-09-19 12:42:38 +02:00
Yann Lanthony
b75ed86fa1 [nodes][aliceVision] bump FeatureMatching version
attributes have been changed since last release, without version being increased
2019-01-31 09:52:52 +01:00
Fabien Castan
349de9a3a6 [nodes] expose estimator parameters on sfm and features matching 2019-01-28 10:52:48 +01:00
Yann Lanthony
168b573e36 [nodes][aliceVision] mark advanced parameters 2018-12-20 11:17:23 +01:00
Yann Lanthony
2a410d07ea [nodes][aliceVision] add initial version on nodes 2018-07-19 13:50:45 +02:00
Yann Lanthony
346277629a [nodes] use 'desc.Node.internalFolder' in outputs values
* avoid duplicating the same string everywhere
* don't override 'internalFolder' with the same value default value in subclasses
2018-07-19 13:50:45 +02:00
Grégoire De Lillo
98439ddef7 [nodes] Rename geometricModel in geometricFilterType 2018-06-22 18:23:45 +02:00
Grégoire De Lillo
e27a2145b7 [nodes] Formatting and small fixes 2018-06-21 16:34:57 +02:00
Grégoire De Lillo
50f01c4222 [nodes] Use lower case for imageDescriber type and preset 2018-06-21 16:34:57 +02:00
Grégoire De Lillo
236a82ece8 [nodes] Add support for multiple features & matches folders 2018-06-21 16:34:57 +02:00
Fabien Castan
d892a5c54f [nodes] FeatureMatching: add H Growing 2018-06-15 19:25:32 +02:00
Fabien Castan
3ff3308700
Merge pull request #90 from alicevision/dev_removeCereal
Add support for AliceVision dev_removeCereal branch
2018-02-23 10:43:08 +01:00
Gregoire De Lillo
aa9733cd10 [nodes] featureMatching : remove fileExtension option 2018-02-06 17:24:05 +01:00
Yann Lanthony
d5f2ac76bc [nodes] FeatureMatching: improve description layout 2018-02-05 19:18:12 +01:00
Yann Lanthony
839d8c5fb6 [nodes] fix savePutativeMatch default value 2018-02-02 17:50:56 +01:00
Fabien Castan
65b7bd74ab [nodes] featureMatching: remove useless parameters 2017-12-11 17:11:45 +01:00
Yann Lanthony
e8c579c942 [core] parallelization: introduce the notion of node 'size'
* node size is an estimation of the number of element to process on a given node, that may be used for parallelization.
* replace the explicit reference to an attribute on a node (Parallelization.inputListParamName)
* size can be:
  * dynamic: depends on the size of the node connected to a specific Attribute
  * static
2017-11-17 18:46:21 +01:00
Yann Lanthony
03058f4860 [nodes] turn several parameters into Choices 2017-11-17 17:56:33 +01:00
Yann Lanthony
5d40790555 [nodes] update aliceVision nodes
* remove non-pertinent parameters
* fix parameters types / description
* tweak value ranges
* fix incorrect uids
* update default values
2017-11-13 20:31:16 +01:00
Fabien Castan
aa0f985077 [nodes] aliceVision: update param names to "folder" 2017-11-10 19:32:08 +01:00
Fabien Castan
1e4f8f8a61 Add chunk notion for parallelization and implement specific updateInternals in CameraInit node
* Add chunk notion for parallelization
* Allows Node desc to implement custom updateInternals
* CameraInit node implement a specific updateInternals to update the
input image list
* FeatureExtraction, FeatureMatching, DepthMap, DepthMapFilter:
implement parallelization
2017-11-07 15:47:14 +01:00
Yann Lanthony
16e8037fd7 [core] change Attributes declaration on Node description
Inputs and outputs Attributes are now declared in two separate lists
* no more isOutput field on Attribute description
* guarantee attributes order (was not the case in Python2 with class attributes)
* Attribute's name is now part of its description

Note: for now, input and output Attributes are still stored in a single model inside a Graph.
2017-10-31 19:47:32 +01:00
Fabien Castan
edd14691fc [nodes] use non-exclusive choice for describerTypes param 2017-10-19 12:30:05 +02:00
Fabien Castan
d42c44af07 [nodes] verbose param should not invalidate 2017-10-19 12:27:30 +02:00
Fabien Castan
287c0f13ce [core] split Param into specific types and update nodes accordingly 2017-10-16 12:23:59 +02:00
Fabien Castan
aacdf32915 Move nodes into subfolders 2017-10-16 12:23:58 +02:00
Renamed from meshroom/nodes/FeatureMatching.py (Browse further)