Commit graph

2673 commits

Author SHA1 Message Date
Loïc Vital
f8406aa6da [docs] python2 compatibility 2022-10-11 11:14:45 +02:00
Loïc Vital
b2db98f128 [doc] sphinx documentation setup 2022-10-11 09:59:33 +02:00
Fabien Castan
7382511417
Merge pull request #1788 from alicevision/dev/centerCopyPasteNodes
[ui] Paste nodes at the center of the Graph Editor when it does not contain the mouse
2022-10-10 20:46:28 +02:00
Candice Bentéjac
6cbeeebb9c [ui] Viewer2D: Fix warnings on some null attributes
Fix the QML warning "TypeError: Cannot read property 'status' of
null".
2022-10-10 18:23:03 +02:00
Candice Bentéjac
ff4620dc2f [ui] Viewer2D: Enable HDR viewer by default if it is available
If the HDR viewer is unavailable, load the classic 8bit image viewer,
but do not allow the user to switch to it anymore if the HDR viewer
is available unless a specific environment variable has been provided.
2022-10-10 18:22:46 +02:00
Fabien Castan
33e3ba5413
Merge pull request #1790 from alicevision/dev/updateTemplates
[pipelines] Update CameraInit version from 7.0 to 8.0 in templates
2022-10-10 09:42:07 +02:00
Loïc Vital
3a654ca8f8 minor correction for improving quality in static code analysis 2022-10-04 17:05:22 +02:00
Loïc Vital
6250190519 [ui] default value for undefined log-line to remove qml warnings 2022-10-04 11:06:04 +02:00
Loïc Vital
3e2478bd24 [ui] show tooltip when hovering over line number or color bar 2022-10-04 10:54:00 +02:00
Loïc Vital
f4b8cb080d [ui] interpolated color scale from grey to red 2022-10-03 17:55:28 +02:00
Loïc Vital
5b973cb349 [ui] using coherent format for elapsed time 2022-10-03 16:26:57 +02:00
Loïc Vital
c2f8c0f97a [ui] color bar fills line heigt 2022-10-03 16:11:08 +02:00
Candice Bentéjac
4fe1ad1eef [pipelines] Update CameraInit version from 7.0 to 8.0 in templates 2022-10-03 15:05:09 +02:00
Candice Bentéjac
021770a424 [ui] Center pasted nodes in GraphEditor when it does not contain the mouse
When using the Edit > Paste menu, or when pressing Ctrl+V while the Graph
Editor has the focus but the mouse is not contained in it, there is no
current mouse position in the GraphEditor so the position that is provided
to the "pasteNodes" function is the last known mouse position, which is
oftentimes on the border of the GraphEditor.

This commit automatically sets the mouse's position to the center of
the GraphEditor, and "builds" the zone containing the pasted nodes around
it.
2022-10-03 11:13:52 +02:00
Loïc Vital
d4bdbeef12 [ui] some comments 2022-09-30 12:24:02 +02:00
Loïc Vital
627664e167 [ui] add tooltip on lineNumber Labels to show elapsed time 2022-09-30 11:59:40 +02:00
Loïc Vital
e7c84b9483 [ui] use ListModel for storing log-line and duration to avoid evaluation order issues 2022-09-30 11:06:41 +02:00
Fabien Castan
243c278bcc
Merge pull request #1778 from alicevision/dev/lv/useLastPathForOpenSave
Use most recent project as base folder for file dialogs
2022-09-28 23:06:54 +02:00
Fabien Castan
5079bba633
Merge pull request #1782 from alicevision/fix/copyPasteGraphEditor
[ui] Restrain the "copy/paste nodes" shortcuts to the GraphEditor
2022-09-28 23:01:22 +02:00
Fabien Castan
79e8202d88
Merge pull request #1784 from alicevision/fix/uidNodes
Fix and prevent mismatches between an attribute's type and its default value's type
2022-09-28 22:58:20 +02:00
Candice Bentéjac
1275975c6a [core] Check that ranges of a node's attributes are valid before loading it
For IntParam and FloatParam, which may have ranges, check before loading
the node that the non-null ranges are of the same type as the attribute.
If at least a range is not correct (e.g. "(0, 10, 0.1)" for a FloatParam,
for which "(0.0, 10.0, 0.1)" is expected), then the node is rejected (in
the same manner as when a default value is deemed invalid).
2022-09-28 10:47:00 +02:00
Candice Bentéjac
e7290313bf [nodes] Align FloatParams' and IntParams' ranges with their params' type 2022-09-28 10:41:39 +02:00
Candice Bentéjac
545f3a7218 [core] Check that the description of a node is correct before loading it
At Meshroom's launch, check that every node we attempt to load has a
valid description, i.e. that every parameter has a default value that
matches its parameter's type.

If there is at least one parameter with an incorrect default value,
the node is not loaded and a corresponding message will be displayed.

This prevents the user from loading erroneous nodes that may lead to
unexpected behaviours (such as a change of a node's UID between the
moment when it is written and the moment it is loaded).
2022-09-28 10:39:18 +02:00
Loïc Vital
7b286ff901 [ui] parse log lines to find duration when possible and color line number accordingly 2022-09-27 18:21:18 +02:00
Fabien Castan
77a9796ca3
Merge pull request #1783 from alicevision/dev/ionbuild
add a script to launch meshroom under ion environment
2022-09-27 17:00:46 +02:00
Candice Bentéjac
5b45182bcb [tests] Check that UIDs are identical when writing and loading a graph 2022-09-26 18:18:14 +02:00
Candice Bentéjac
1a63a5f819 [nodes] Align all nodes' default values with their params' type
Fix default values for:
- DepthMap: refineSigma (FloatParam); use float instead of int
- ImageMasking: hsvMaxSaturation (FloatParam); use float instead
of int
- ImageMasking: hsvMaxValue (FloatParam); use float instead of
int
- Meshing: estimateSpaceMinObservationAngle (FloatParam); use
float instead of int
- PanoramaInit: yawCW (BoolParam); use bool instead of int
2022-09-26 18:11:02 +02:00
Candice Bentéjac
83f1876e2c [nodes] CameraInit: set float default values for FloatParams
Fix the parameters with default values that do not correspond to
the parameters' types. For CameraInit, all the default values of
FloatParams that are set with integers are replaced with actual
float values.

These default values with an erroneous type would cause changes
in the CameraInit's UID when the intrinsics' default values were
written (with values of the correct type) and when they were
loaded (with values of the wrong type).
2022-09-26 17:48:57 +02:00
Candice Bentéjac
58784fb6ff [ui] Restrain the "copy/paste nodes" shortcuts to the GraphEditor
If a Ctrl+C or Ctrl+V shortcut is performed outside the GraphEditor,
the performed action should not be a copy or a paste of the nodes, but
the own copy/paste of the current element (e.g. if a Ctrl+C is made on
on the NodeEditor, then the copied element should be the one selected
in the NodeEditor, not the currently selected node).
2022-09-26 09:56:28 +02:00
Fabien Servant
06aa16243d [ION] wrong variable in script 2022-09-26 08:42:19 +01:00
Fabien Servant
595bf4aa1b [ION] adding qt plugin path 2022-09-26 08:39:59 +01:00
Fabien Castan
0f5ffd7d7c
Merge pull request #1777 from alicevision/fix/templateSaving
[core] Set the "template" flag to "false" when saving a project as a regular file
2022-09-24 00:21:10 +02:00
Loïc Vital
d0fcb67d1c [ui] rename Import Scene to Import Project for coherent naming 2022-09-23 11:22:36 +02:00
Loïc Vital
f4352e5254 [ui] file dialogs: use most recent project dir instead of system default 2022-09-23 09:39:22 +02:00
Candice Bentéjac
aa728919c8 [core] Explicitly set "template" key to false when saving as a regular file 2022-09-23 09:20:44 +02:00
Loïc Vital
a5c18606bc use most recent project as base folder when using Open action 2022-09-22 16:42:46 +02:00
Fabien Servant
263c806bfe [bin] add ion script for launch 2022-09-16 12:30:35 +01:00
Fabien Castan
f9e5a5809c
Merge pull request #1747 from alicevision/fix/uidCameraInit
[nodes] CameraInit: all intrinsics parameters should invalidate
2022-09-15 18:32:58 +02:00
Fabien Castan
95bb93b4bf [nodes] CameraInit: upgrade node version
Change in uid should modify the node version and thus require a manual upgrade of the node when loading previous scenes.
2022-09-15 17:29:15 +02:00
Fabien Castan
032ac712fd [nodes] CameraInit: all intrinsics parameters should invalidate 2022-09-15 17:29:15 +02:00
Fabien Castan
ee20136f82
Merge pull request #1764 from alicevision/dev/displayComputeTime
[ui] Display computation time for "running" or "finished" nodes
2022-09-10 00:27:34 +02:00
Candice Bentéjac
5542516ba4 [ui] Display computation time for "running" or "finished" nodes 2022-09-09 16:36:43 +02:00
Fabien Castan
277384f5ef
Merge pull request #1390 from alicevision/dev/nodeSfmTransformCamerasXAxis
[nodes] SfMTransform: add auto_from_cameras_x_axis
2022-09-08 18:29:54 +02:00
Fabien Castan
27faf9f77c
Merge pull request #1758 from alicevision/dev/copyPasteNode
Support copying/pasting a node in the Graph Editor
2022-09-08 17:42:12 +02:00
Candice Bentéjac
61e0482a21 Add an offset to the position of pasted nodes if a node is hovered
If a node is being hovered when the user performs the paste, an
offset is added to the mouse's position, both in the horizontal and
vertical directions. This aims at avoiding a complete overlap with
the nodes on top of which the clipboard content is pasted.
2022-09-08 15:21:57 +02:00
Fabien Castan
267aff5a09
Merge pull request #1767 from alicevision/bugfix-tonode-submit
removed duplicated call to findnodes
2022-09-07 20:21:30 +02:00
Fabien Castan
5ad4c82f39
Merge pull request #1768 from luzpaz/typos
Fix various typos
2022-09-07 20:19:06 +02:00
luz paz
25b091b304 Fix various typos
Found via `codespell`
2022-09-07 10:51:41 -04:00
Fabien Castan
cc7d45eb74
Merge pull request #1740 from alicevision/dev/noIdentityMatches
[Feature Matching] Add an option to remove matches without enough motion
2022-09-07 16:04:23 +02:00
Fabien Castan
64e497e2b5
[nodes] FeatureMatching: expose minRequired2DMotion 2022-09-07 13:15:32 +02:00