3pp-mirror/Meshroom
1
0
Fork 0
mirror of https://github.com/alicevision/Meshroom.git synced 2025-07-15 15:55:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

[core] plugins: Remove register/unregisterPlugin methods

Browse source 
Remove the methods and perform the registration/unregistration directly
within the functions that called them. This simplifies the code and
prevents ambiguity between the different functions.
This commit is contained in:
Candice Bentéjac 2025-06-04 21:21:42 +02:00
parent 3c57afb4d0
commit a19c306cf3
1 changed files with 4 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

33
meshroom/core/plugins.py
View file

@ -333,7 +333,8 @@ class NodePluginManager(BaseObject):
if not self.getPlugin(plugin.name): if not self.getPlugin(plugin.name):
self._plugins[plugin.name] = plugin self._plugins[plugin.name] = plugin
if registerNodePlugins: if registerNodePlugins:
self.registerPlugin(plugin.name) for node in plugin.nodes:
self.registerNode(plugin.nodes[node])
def removePlugin(self, plugin: Plugin, unregisterNodePlugins: bool = True): def removePlugin(self, plugin: Plugin, unregisterNodePlugins: bool = True):
""" """
@ -348,7 +349,8 @@ class NodePluginManager(BaseObject):
""" """
if self.getPlugin(plugin.name): if self.getPlugin(plugin.name):
if unregisterNodePlugins: if unregisterNodePlugins:
self.unregisterPlugin(plugin.name) for node in plugin.nodes.values():
self.unregisterNode(node)
del self._plugins[plugin.name] del self._plugins[plugin.name]
def getRegisteredNodePlugins(self) -> dict[str: NodePlugin]: def getRegisteredNodePlugins(self) -> dict[str: NodePlugin]:
@ -372,33 +374,6 @@ class NodePluginManager(BaseObject):
return self._nodePlugins[name] return self._nodePlugins[name]
return None return None
def registerPlugin(self, name: str):
"""
Register all the NodePlugins contained in the Plugin loaded as "name".
Args:
name: the name of the Plugin whose NodePlugins will be registered.
"""
plugin = self.getPlugin(name)
if plugin:
for node in plugin.nodes:
self.registerNode(plugin.nodes[node])
else:
logging.error(f"No loaded Plugin named {name}.")
def unregisterPlugin(self, name: str):
"""
Unregister all the NodePlugins contained in the Plugin loaded as "name"
that are currently registered.
Args:
name: the name of the Plugin whose NodePlugins will be unregistered.
"""
plugin = self.getPlugin(name)
if plugin:
for node in plugin.nodes.values():
self.unregisterNode(node)
def registerNode(self, nodePlugin: NodePlugin): def registerNode(self, nodePlugin: NodePlugin):
""" """
Register a node plugin. A registered node plugin will become instantiable. Register a node plugin. A registered node plugin will become instantiable.