3pp-mirror/snapcast
1
0
Fork 0
mirror of https://github.com/badaix/snapcast.git synced 2025-05-18 19:46:14 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix crash if message deserialization fails

Browse source
This commit is contained in:
badaix 2021-06-26 22:02:40 +02:00
parent e94b5534b7
commit fba20fb7fe
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
client/client_connection.cpp
View file

@ -237,6 +237,8 @@ void ClientConnection::getNextMessage(const MessageHandler<msg::BaseMessage>& ha
} }
auto response = msg::factory::createMessage(base_message_, buffer_.data()); auto response = msg::factory::createMessage(base_message_, buffer_.data());
if (!response)
LOG(WARNING, LOG_TAG) << "Failed to deserialize message of type: " << base_message_.type << "\n";
for (auto iter = pendingRequests_.begin(); iter != pendingRequests_.end(); ++iter) for (auto iter = pendingRequests_.begin(); iter != pendingRequests_.end(); ++iter)
{ {
auto request = *iter; auto request = *iter;

5
client/controller.cpp
View file

@ -124,6 +124,11 @@ void Controller::getNextMessage()
return; return;
} }
if (!response)
{
return getNextMessage();
}
if (response->type == message_type::kWireChunk) if (response->type == message_type::kWireChunk)
{ {
if (stream_ && decoder_) if (stream_ && decoder_)