From f6b1e3f5d490dde0765fc8f7f1ed370211551430 Mon Sep 17 00:00:00 2001
From: badaix <johannes.pohl@badaix.de>
Date: Sun, 9 Feb 2025 21:21:03 +0100
Subject: [PATCH] Log auth error

---
 server/control_requests.cpp        | 6 ++++++
 server/streamreader/pcm_stream.hpp | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/server/control_requests.cpp b/server/control_requests.cpp
index 27b25696..4e6ca221 100644
--- a/server/control_requests.cpp
+++ b/server/control_requests.cpp
@@ -893,14 +893,20 @@ void ServerAuthenticateRequest::execute(const jsonrpcpp::request_ptr& request, A
 
     auto scheme = request->params().get<std::string>("scheme");
     auto param = request->params().get<std::string>("param");
+    // TODO: don't log passwords
     LOG(INFO, LOG_TAG) << "Authorization scheme: " << scheme << ", param: " << param << "\n";
     auto ec = authinfo.authenticate(scheme, param);
 
     std::shared_ptr<jsonrpcpp::Response> response;
     if (ec)
+    {
+        LOG(ERROR, LOG_TAG) << "Auth error: " << ec.detailed_message() << "\n";
         response = std::make_shared<jsonrpcpp::Response>(request->id(), jsonrpcpp::Error(ec.detailed_message(), ec.value()));
+    }
     else
+    {
         response = std::make_shared<jsonrpcpp::Response>(request->id(), "ok");
+    }
     // LOG(DEBUG, LOG_TAG) << response->to_json().dump() << "\n";
 
     on_response(std::move(response), nullptr);
diff --git a/server/streamreader/pcm_stream.hpp b/server/streamreader/pcm_stream.hpp
index 6ca389c9..d18f43a2 100644
--- a/server/streamreader/pcm_stream.hpp
+++ b/server/streamreader/pcm_stream.hpp
@@ -116,7 +116,7 @@ public:
         virtual void onChunkRead(const PcmStream* pcmStream, const msg::PcmChunk& chunk) = 0;
         /// Chunk @p chunk with duration @p duration of stream @pcmStream has been encoded
         virtual void onChunkEncoded(const PcmStream* pcmStream, std::shared_ptr<msg::PcmChunk> chunk, double duration) = 0;
-        /// Stream @p pcmStream muissed to read audio with duration @p ms 
+        /// Stream @p pcmStream muissed to read audio with duration @p ms
         virtual void onResync(const PcmStream* pcmStream, double ms) = 0;
     };