3pp-mirror/snapcast
1
0
Fork 0
mirror of https://github.com/badaix/snapcast.git synced 2025-07-23 11:27:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

Split returns empty last element

Browse source
This commit is contained in:
badaix 2024-07-04 21:56:30 +02:00
parent ad6ab1ad3b
commit 15a3cf9680
2 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
common/utils/string_utils.cpp
View file

@ -162,6 +162,10 @@ std::vector<std::string>& split(const std::string& s, char delim, std::vector<st
{ {
elems.push_back(item); elems.push_back(item);
} }
if (!s.empty() && (s.back() == delim))
elems.emplace_back("");
return elems; return elems;
} }

19
test/test_main.cpp
View file

@ -48,7 +48,21 @@ TEST_CASE("String utils")
using namespace utils::string; using namespace utils::string;
REQUIRE(ltrim_copy(" test") == "test"); REQUIRE(ltrim_copy(" test") == "test");
auto strings = split("1*2", '*'); auto strings = split("", '*');
REQUIRE(strings.empty());
strings = split("*", '*');
REQUIRE(strings.size() == 2);
REQUIRE(strings[0] == "");
REQUIRE(strings[1] == "");
strings = split("**", '*');
REQUIRE(strings.size() == 3);
REQUIRE(strings[0] == "");
REQUIRE(strings[1] == "");
REQUIRE(strings[2] == "");
strings = split("1*2", '*');
REQUIRE(strings.size() == 2); REQUIRE(strings.size() == 2);
REQUIRE(strings[0] == "1"); REQUIRE(strings[0] == "1");
REQUIRE(strings[1] == "2"); REQUIRE(strings[1] == "2");
@ -66,10 +80,11 @@ TEST_CASE("String utils")
REQUIRE(strings[2] == "2"); REQUIRE(strings[2] == "2");
strings = split("*1*2*", '*'); strings = split("*1*2*", '*');
REQUIRE(strings.size() == 3); REQUIRE(strings.size() == 4);
REQUIRE(strings[0] == ""); REQUIRE(strings[0] == "");
REQUIRE(strings[1] == "1"); REQUIRE(strings[1] == "1");
REQUIRE(strings[2] == "2"); REQUIRE(strings[2] == "2");
REQUIRE(strings[3] == "");
std::vector<std::string> vec{"1", "2", "3"}; std::vector<std::string> vec{"1", "2", "3"};
REQUIRE(container_to_string(vec) == "1, 2, 3"); REQUIRE(container_to_string(vec) == "1, 2, 3");