From 611d04eaaa7c0a8ab75a91b6e9c4599cb6afd29d Mon Sep 17 00:00:00 2001 From: Luke Vella Date: Tue, 7 Mar 2023 09:42:27 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=AC=20Update=20email=20subject=20lines?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- apps/web/src/server/routers/polls.ts | 4 ++-- apps/web/src/server/routers/polls/participants.ts | 2 +- apps/web/src/utils/api-utils.ts | 2 +- apps/web/tests/create-delete-poll.spec.ts | 4 +--- apps/web/tests/vote-and-comment.spec.ts | 2 +- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/apps/web/src/server/routers/polls.ts b/apps/web/src/server/routers/polls.ts index 0b9ecb985..8c6289773 100644 --- a/apps/web/src/server/routers/polls.ts +++ b/apps/web/src/server/routers/polls.ts @@ -150,7 +150,7 @@ export const polls = router({ if (poll.verified) { await sendEmail("NewPollEmail", { to: input.user.email, - subject: `Your poll for ${poll.title} has been created`, + subject: `${poll.title} has been created`, props: { title: poll.title, name: input.user.name, @@ -165,7 +165,7 @@ export const polls = router({ await sendEmail("NewPollVerificationEmail", { to: input.user.email, - subject: `Your poll for ${poll.title} has been created`, + subject: `${poll.title} has been created`, props: { title: poll.title, name: input.user.name, diff --git a/apps/web/src/server/routers/polls/participants.ts b/apps/web/src/server/routers/polls/participants.ts index 741d5a97c..7b974630d 100644 --- a/apps/web/src/server/routers/polls/participants.ts +++ b/apps/web/src/server/routers/polls/participants.ts @@ -100,7 +100,7 @@ export const participants = router({ emailsToSend.push( sendEmail("NewParticipantConfirmationEmail", { to: email, - subject: `Response submitted: ${poll.title}`, + subject: `Response submitted for ${poll.title}`, props: { name, title: poll.title, diff --git a/apps/web/src/utils/api-utils.ts b/apps/web/src/utils/api-utils.ts index 261b13189..95e5d6a37 100644 --- a/apps/web/src/utils/api-utils.ts +++ b/apps/web/src/utils/api-utils.ts @@ -56,7 +56,7 @@ export const sendNotification = async ( case "newParticipant": await sendEmail("NewParticipantEmail", { to: poll.user.email, - subject: `New participant on ${poll.title}`, + subject: `Response received on ${poll.title}`, props: { name: poll.user.name, participantName: action.participantName, diff --git a/apps/web/tests/create-delete-poll.spec.ts b/apps/web/tests/create-delete-poll.spec.ts index 9c850188c..fe3875a61 100644 --- a/apps/web/tests/create-delete-poll.spec.ts +++ b/apps/web/tests/create-delete-poll.spec.ts @@ -59,9 +59,7 @@ test.describe.serial(() => { wait: 5000, }); - expect(email.headers.subject).toBe( - "Your poll for Monthly Meetup has been created", - ); + expect(email.headers.subject).toBe("Monthly Meetup has been created"); const $ = load(email.html); const verifyLink = $("#verifyEmailUrl").attr("href"); diff --git a/apps/web/tests/vote-and-comment.spec.ts b/apps/web/tests/vote-and-comment.spec.ts index ecdddbba2..574c9b5fa 100644 --- a/apps/web/tests/vote-and-comment.spec.ts +++ b/apps/web/tests/vote-and-comment.spec.ts @@ -76,7 +76,7 @@ test.describe.parallel(() => { wait: 5000, }); - expect(email.headers.subject).toBe("Response submitted: Lunch Meeting"); + expect(email.headers.subject).toBe("Response submitted for Lunch Meeting"); const $ = load(email.html); const href = $("#editSubmissionUrl").attr("href");