add errors to array and remove fail flag

This commit is contained in:
Dave Machado 2017-07-28 11:25:35 -04:00
parent 60fbe68f78
commit e2b71b22c4

View file

@ -1,11 +1,17 @@
#!/usr/bin/env ruby #!/usr/bin/env ruby
auth_keys = ['apiKey', 'OAuth', 'X-Mashape-Key', 'No'] auth_keys = ['apiKey', 'OAuth', 'X-Mashape-Key', 'No']
punctuation = ['.', '?', '!'] punctuation = ['.', '?', '!']
https_keys = ['Yes', 'No'] https_keys = ['Yes', 'No']
args = ARGV args = ARGV
filename = args[0] filename = args[0]
fail_flag = false $errors = []
File.foreach(filename).with_index do |line, line_num|
def add_error(line_num, message)
$errors.push("(L%03d) #{message}" % line_num)
end
File.foreach(filename).with_index do | line, line_num |
line_num += 1 line_num += 1
if line.start_with?('|') if line.start_with?('|')
# Skip table schema lines # Skip table schema lines
@ -17,39 +23,37 @@ File.foreach(filename).with_index do |line, line_num|
# First character should be capitalized # First character should be capitalized
desc_val = values[2].lstrip.chop desc_val = values[2].lstrip.chop
if !/[[:upper:]]/.match(desc_val[0]) if !/[[:upper:]]/.match(desc_val[0])
puts "(#{line_num}) Invalid Description (first char not uppercase): #{desc_val}" add_error(line_num, "Invalid Description (first char not uppercase): #{desc_val}")
fail_flag = true
end end
# value should not be punctuated # value should not be punctuated
last_char = desc_val[desc_val.length-1] last_char = desc_val[desc_val.length-1]
if punctuation.include?(last_char) if punctuation.include?(last_char)
puts "(#{line_num}) Invalid Description (description should not end with \"#{last_char}\")" add_error(line_num, "Invalid Description (description should not end with \"#{last_char}\")")
fail_flag = true
end end
#################### AUTH #################### #################### AUTH ####################
# Values should conform to valid options only # Values should conform to valid options only
auth_val = values[3].lstrip.chop.tr('``', '') auth_val = values[3].lstrip.chop.tr('``', '')
if !auth_keys.include?(auth_val) if !auth_keys.include?(auth_val)
puts "(#{line_num}) Invalid Auth (not a valid option): #{auth_val}" add_error(line_num, "Invalid Auth (not a valid option): #{auth_val}")
fail_flag = true
end end
#################### HTTPS ################### #################### HTTPS ###################
# Values should be either "Yes" or "No" # Values should be either "Yes" or "No"
https_val = values[4].lstrip.chop https_val = values[4].lstrip.chop
if !https_keys.include?(https_val) if !https_keys.include?(https_val)
puts "(#{line_num}) Invalid HTTPS: (must use \"Yes\" or \"No\"): #{https_val}" add_error(line_num, "(#{line_num}) Invalid HTTPS: (must use \"Yes\" or \"No\"): #{https_val}")
fail_flag = true
end end
#################### LINK #################### #################### LINK ####################
# Url should be wrapped in "[Go!]" view # Url should be wrapped in "[Go!]" view
link_val = values[5].lstrip.chop link_val = values[5].lstrip.chop
if !link_val.start_with?("[Go!](") || !link_val.end_with?(')') if !link_val.start_with?("[Go!](") || !link_val.end_with?(')')
puts "(#{line_num}) Invalid Link: (format should be \"[Go!](<LINK>)\"): #{link_val}" add_error(line_num, "(#{line_num}) Invalid Link: (format should be \"[Go!](<LINK>)\"): #{link_val}")
fail_flag = true
end end
end end
end end
if fail_flag if $errors.length > 0
$errors.each do | e |
puts e
end
exit(1) exit(1)
else else
exit(0) exit(0)