mirror of
https://github.com/pomerium/pomerium.git
synced 2025-05-01 11:26:29 +02:00
b90885b4c1
In 35af5c0b91, the check for multiple
cache servers in NotifyJoin is made to be done in a goroutine. That can
lead to a data race, because the memberlist can be changed at the time
the goroutine was run. go warns about this race when test memberlist was
run with "-race".
To fix this, we pass the nil check as argument to goroutine.
96 lines
2.5 KiB
Go
96 lines
2.5 KiB
Go
package cache
|
|
|
|
import (
|
|
"bufio"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
stdlog "log"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/hashicorp/memberlist"
|
|
"github.com/rs/zerolog"
|
|
|
|
"github.com/pomerium/pomerium/internal/log"
|
|
)
|
|
|
|
type memberlistHandler struct {
|
|
cfg *memberlist.Config
|
|
memberlist *memberlist.Memberlist
|
|
log zerolog.Logger
|
|
}
|
|
|
|
func (c *Cache) runMemberList(ctx context.Context) error {
|
|
mh := new(memberlistHandler)
|
|
mh.log = log.With().Str("service", "memberlist").Logger()
|
|
|
|
pr, pw := io.Pipe()
|
|
defer pw.Close()
|
|
defer pr.Close()
|
|
|
|
mh.cfg = memberlist.DefaultLANConfig()
|
|
mh.cfg.Events = mh
|
|
mh.cfg.Logger = stdlog.New(pw, "", 0)
|
|
go mh.runLogHandler(pr)
|
|
|
|
var err error
|
|
mh.memberlist, err = memberlist.Create(mh.cfg)
|
|
if err != nil {
|
|
return fmt.Errorf("memberlist: error creating memberlist: %w", err)
|
|
}
|
|
|
|
// the only way memberlist would be empty here, following create is if
|
|
// the current node suddenly died. Still, we check to be safe.
|
|
if len(mh.memberlist.Members()) == 0 {
|
|
return errors.New("memberlist: can't find self")
|
|
}
|
|
|
|
mh.log.Info().Str("cluster_url", c.deprecatedCacheClusterDomain).Msg("checking for existing cluster members")
|
|
|
|
joined, err := mh.memberlist.Join([]string{c.deprecatedCacheClusterDomain, mh.memberlist.Members()[0].Addr.String()})
|
|
if err != nil {
|
|
return fmt.Errorf("memberlist: failed to join cluster: %w", err)
|
|
}
|
|
|
|
mh.log.Info().Int("contacted", joined).Interface("members", mh.memberlist.Members()).Msg("contacted nodes")
|
|
if mh.memberlist.NumMembers() > 1 {
|
|
mh.log.Error().Msg("multiple cache servers not supported")
|
|
}
|
|
<-ctx.Done()
|
|
err = mh.memberlist.Leave(1 * time.Second)
|
|
if err != nil {
|
|
mh.log.Error().Err(err).Msg("failed to leave cluster")
|
|
}
|
|
return mh.memberlist.Shutdown()
|
|
}
|
|
|
|
func (mh *memberlistHandler) NotifyJoin(node *memberlist.Node) {
|
|
mh.log.Debug().Interface("node", node).Msg("node joined")
|
|
|
|
go func(memberListNotNil bool) {
|
|
if memberListNotNil && mh.memberlist.NumMembers() > 1 {
|
|
mh.log.Error().Msg("detected multiple cache servers, which is not supported")
|
|
}
|
|
}(mh.memberlist != nil)
|
|
}
|
|
|
|
func (mh *memberlistHandler) NotifyLeave(node *memberlist.Node) {
|
|
mh.log.Debug().Interface("node", node).Msg("node left")
|
|
}
|
|
|
|
func (mh *memberlistHandler) NotifyUpdate(node *memberlist.Node) {
|
|
mh.log.Debug().Interface("node", node).Msg("node updated")
|
|
}
|
|
|
|
func (mh *memberlistHandler) runLogHandler(r io.Reader) {
|
|
br := bufio.NewReader(r)
|
|
for {
|
|
str, err := br.ReadString('\n')
|
|
if err != nil {
|
|
break
|
|
}
|
|
mh.log.Debug().Msg(strings.TrimSpace(str))
|
|
}
|
|
}
|