mirror of
https://github.com/pomerium/pomerium.git
synced 2025-04-29 18:36:30 +02:00
Currently we always add an invalid_client_certificate deny rule to all PPL policies. Instead, let's add this rule only when a client CA is configured. This way, if a user is not using client certificates at all, they won't see any reason strings related to client certificates in the authorize logs. Change the "valid-client-certificate-or-none-required" reason string to just "valid-client-certificate" accordingly. Pass the main Evaluator config to NewPolicyEvaluator so that we can determine whether there is a client CA configured or not. Extract the existing default deny rule to a separate method. Add unit tests exercising the new behavior.
88 lines
1.8 KiB
Go
88 lines
1.8 KiB
Go
package config
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"sort"
|
|
|
|
"github.com/pomerium/pomerium/pkg/policy/parser"
|
|
)
|
|
|
|
// ToPPL converts a policy into Pomerium Policy Language.
|
|
func (p *Policy) ToPPL() *parser.Policy {
|
|
ppl := &parser.Policy{}
|
|
|
|
allowRule := parser.Rule{Action: parser.ActionAllow}
|
|
if p.AllowPublicUnauthenticatedAccess {
|
|
allowRule.Or = append(allowRule.Or,
|
|
parser.Criterion{
|
|
Name: "accept",
|
|
Data: parser.Boolean(true),
|
|
})
|
|
}
|
|
if p.CORSAllowPreflight {
|
|
allowRule.Or = append(allowRule.Or,
|
|
parser.Criterion{
|
|
Name: "cors_preflight",
|
|
Data: parser.Boolean(true),
|
|
})
|
|
}
|
|
if p.AllowAnyAuthenticatedUser {
|
|
allowRule.Or = append(allowRule.Or,
|
|
parser.Criterion{
|
|
Name: "authenticated_user",
|
|
Data: parser.Boolean(true),
|
|
})
|
|
}
|
|
for _, ad := range p.AllAllowedDomains() {
|
|
allowRule.Or = append(allowRule.Or,
|
|
parser.Criterion{
|
|
Name: "domain",
|
|
Data: parser.Object{
|
|
"is": parser.String(ad),
|
|
},
|
|
})
|
|
}
|
|
for _, aic := range p.AllAllowedIDPClaims() {
|
|
var ks []string
|
|
for k := range aic {
|
|
ks = append(ks, k)
|
|
}
|
|
sort.Strings(ks)
|
|
for _, k := range ks {
|
|
for _, v := range aic[k] {
|
|
bs, _ := json.Marshal(v)
|
|
data, _ := parser.ParseValue(bytes.NewReader(bs))
|
|
allowRule.Or = append(allowRule.Or,
|
|
parser.Criterion{
|
|
Name: "claim",
|
|
SubPath: k,
|
|
Data: data,
|
|
})
|
|
}
|
|
}
|
|
}
|
|
for _, au := range p.AllAllowedUsers() {
|
|
allowRule.Or = append(allowRule.Or,
|
|
parser.Criterion{
|
|
Name: "user",
|
|
Data: parser.Object{
|
|
"is": parser.String(au),
|
|
},
|
|
},
|
|
parser.Criterion{
|
|
Name: "email",
|
|
Data: parser.Object{
|
|
"is": parser.String(au),
|
|
},
|
|
})
|
|
}
|
|
ppl.Rules = append(ppl.Rules, allowRule)
|
|
|
|
// append embedded PPL policy rules
|
|
if p.Policy != nil && p.Policy.Policy != nil {
|
|
ppl.Rules = append(ppl.Rules, p.Policy.Policy.Rules...)
|
|
}
|
|
|
|
return ppl
|
|
}
|