mirror of
https://github.com/pomerium/pomerium.git
synced 2025-07-08 12:28:18 +02:00
databroker: add sync-cache (#5639)
## Summary Add a new `SyncCache`: ```go type SyncCache interface { // Clear deletes all the data for the given record type in the sync cache. Clear(recordType string) error // Records yields the databroker records stored in the cache. Records(recordType string) iter.Seq2[*Record, error] // Sync syncs the cache with the databroker. Sync(ctx context.Context, client DataBrokerServiceClient, recordType string) error } ``` The cache maintains databroker records in a local pebble database (which could be on-disk or in-memory). The way it's used is you first call `.Sync(ctx, client, recordType)` and then `.Records(recordType)`, which returns an iterator over all the records. Internally we store the databroker records in a pebble key-value database. Pebble was chosen because its fast and well-tested, but any ordered key-value store would work. The first time we call `SyncLatest` to retrieve all the records. Each subsequent time we call `Sync` with the current server and record versions to retrieve only the changes. This is significantly more efficient than calling `SyncLatest` every time. The primary use for this is in the enterprise-console as part of directory sync to improve performance with large datasets. ## Related issues - [ENG-2401](https://linear.app/pomerium/issue/ENG-2401/enterprise-console-improve-performance-of-directory-sync-using-cached) ## Checklist - [x] reference any related issues - [x] updated unit tests - [x] add appropriate label (`enhancement`, `bug`, `breaking`, `dependencies`, `ci`) - [x] ready for review --------- Co-authored-by: Denis Mishin <dmishin@pomerium.com>
This commit is contained in:
parent
c0a8b79ef1
commit
ff607fa018
5 changed files with 569 additions and 2 deletions
109
pkg/grpc/databroker/sync_cache_test.go
Normal file
109
pkg/grpc/databroker/sync_cache_test.go
Normal file
|
@ -0,0 +1,109 @@
|
|||
package databroker_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"iter"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.opentelemetry.io/otel/trace/noop"
|
||||
grpc "google.golang.org/grpc"
|
||||
"google.golang.org/protobuf/types/known/timestamppb"
|
||||
|
||||
"github.com/pomerium/pomerium/internal/databroker"
|
||||
"github.com/pomerium/pomerium/internal/testutil"
|
||||
databrokerpb "github.com/pomerium/pomerium/pkg/grpc/databroker"
|
||||
"github.com/pomerium/pomerium/pkg/grpc/user"
|
||||
"github.com/pomerium/pomerium/pkg/pebbleutil"
|
||||
"github.com/pomerium/pomerium/pkg/protoutil"
|
||||
)
|
||||
|
||||
func TestSyncCache(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
ctx, cancel := context.WithTimeout(context.Background(), time.Second*15)
|
||||
defer cancel()
|
||||
|
||||
prefix := []byte{1, 2, 3}
|
||||
typeUUID := uuid.MustParse("e86635f2-f7ad-594d-a37e-a447aca46801")
|
||||
|
||||
cc1 := testutil.NewGRPCServer(t, func(s *grpc.Server) {
|
||||
databrokerpb.RegisterDataBrokerServiceServer(s, databroker.New(ctx, noop.NewTracerProvider()))
|
||||
})
|
||||
cc2 := testutil.NewGRPCServer(t, func(s *grpc.Server) {
|
||||
databrokerpb.RegisterDataBrokerServiceServer(s, databroker.New(ctx, noop.NewTracerProvider()))
|
||||
})
|
||||
client1 := databrokerpb.NewDataBrokerServiceClient(cc1)
|
||||
client2 := databrokerpb.NewDataBrokerServiceClient(cc2)
|
||||
|
||||
expected := []*databrokerpb.Record{
|
||||
databrokerpb.NewRecord(&user.User{Id: "u1"}),
|
||||
databrokerpb.NewRecord(&user.User{Id: "u2"}),
|
||||
databrokerpb.NewRecord(&user.User{Id: "u3"}),
|
||||
}
|
||||
res, err := client1.Put(ctx, &databrokerpb.PutRequest{Records: expected})
|
||||
require.NoError(t, err)
|
||||
expected = res.Records
|
||||
|
||||
db := pebbleutil.MustOpenMemory(nil)
|
||||
require.NoError(t, db.Set([]byte("OTHER"), []byte("VALUE"), nil))
|
||||
c := databrokerpb.NewSyncCache(db, prefix)
|
||||
|
||||
assert.NoError(t, c.Sync(ctx, client1, protoutil.GetTypeURL(new(user.User))))
|
||||
actual := collect(t, c.Records(protoutil.GetTypeURL(new(user.User))))
|
||||
testutil.AssertProtoEqual(t, expected, actual)
|
||||
|
||||
assert.Equal(t, [][]byte{
|
||||
append(append(prefix, typeUUID[:]...), 1), // server version
|
||||
append(append(prefix, typeUUID[:]...), 2), // record version
|
||||
append(append(append(prefix, typeUUID[:]...), 3), "u1"...), // record u1
|
||||
append(append(append(prefix, typeUUID[:]...), 3), "u2"...), // record u2
|
||||
append(append(append(prefix, typeUUID[:]...), 3), "u3"...), // record u3
|
||||
[]byte("OTHER"),
|
||||
}, collect(t, pebbleutil.IterateKeys(db, nil)))
|
||||
|
||||
// test adding a new record
|
||||
|
||||
u4 := databrokerpb.NewRecord(&user.User{Id: "u4"})
|
||||
res, err = client1.Put(ctx, &databrokerpb.PutRequest{Records: []*databrokerpb.Record{u4}})
|
||||
require.NoError(t, err)
|
||||
expected = append(expected, res.Records...)
|
||||
|
||||
assert.NoError(t, c.Sync(ctx, client1, protoutil.GetTypeURL(new(user.User))))
|
||||
actual = collect(t, c.Records(protoutil.GetTypeURL(new(user.User))))
|
||||
testutil.AssertProtoEqual(t, expected, actual)
|
||||
|
||||
// test deleting a record
|
||||
|
||||
u4.DeletedAt = timestamppb.Now()
|
||||
_, err = client1.Put(ctx, &databrokerpb.PutRequest{Records: []*databrokerpb.Record{u4}})
|
||||
require.NoError(t, err)
|
||||
expected = expected[:len(expected)-1]
|
||||
|
||||
assert.NoError(t, c.Sync(ctx, client1, protoutil.GetTypeURL(new(user.User))))
|
||||
actual = collect(t, c.Records(protoutil.GetTypeURL(new(user.User))))
|
||||
testutil.AssertProtoEqual(t, expected, actual)
|
||||
|
||||
// test server version change
|
||||
|
||||
assert.NoError(t, c.Sync(ctx, client2, protoutil.GetTypeURL(new(user.User))))
|
||||
actual = collect(t, c.Records(protoutil.GetTypeURL(new(user.User))))
|
||||
assert.Empty(t, actual)
|
||||
|
||||
// make sure clear works but other keys are left untouched
|
||||
|
||||
assert.NoError(t, c.Clear(protoutil.GetTypeURL(new(user.User))))
|
||||
assert.Equal(t, [][]byte{[]byte("OTHER")}, collect(t, pebbleutil.IterateKeys(db, nil)))
|
||||
}
|
||||
|
||||
func collect[T any](tb testing.TB, seq iter.Seq2[T, error]) []T {
|
||||
var records []T
|
||||
for record, err := range seq {
|
||||
require.NoError(tb, err)
|
||||
records = append(records, record)
|
||||
}
|
||||
return records
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue