From fc8de331ae0a616da247feb3ba4e0c848ab6a90f Mon Sep 17 00:00:00 2001 From: Caleb Doxsey Date: Tue, 27 Dec 2022 11:50:50 -0700 Subject: [PATCH] nevermind, add duplicate names --- config/envoyconfig/listeners.go | 12 ++---------- config/envoyconfig/listeners_test.go | 1 + 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/config/envoyconfig/listeners.go b/config/envoyconfig/listeners.go index 3b5c52e9d..a390762c0 100644 --- a/config/envoyconfig/listeners.go +++ b/config/envoyconfig/listeners.go @@ -633,11 +633,7 @@ func getAllServerNames(cfg *config.Config, addr string) ([]string, error) { if err != nil { return nil, err } - for _, sn := range sns { - if !cryptutil.HasCertificateForServerName(certs, sn) { - serverNames.Add(sn) - } - } + serverNames.Add(sns...) } if addr == cfg.Options.GetGRPCAddr() { @@ -645,11 +641,7 @@ func getAllServerNames(cfg *config.Config, addr string) ([]string, error) { if err != nil { return nil, err } - for _, sn := range sns { - if !cryptutil.HasCertificateForServerName(certs, sn) { - serverNames.Add(sn) - } - } + serverNames.Add(sns...) } return serverNames.ToSlice(), nil diff --git a/config/envoyconfig/listeners_test.go b/config/envoyconfig/listeners_test.go index 01d709ebc..44d2c4b0d 100644 --- a/config/envoyconfig/listeners_test.go +++ b/config/envoyconfig/listeners_test.go @@ -1049,6 +1049,7 @@ func Test_getAllDomains(t *testing.T) { "authenticate.example.com", "b.example.com", "c.example.com", + "d.unknown.example.com", } assert.Equal(t, expect, actual) })