3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-08-02 00:10:45 +02:00
Code Issues Projects Releases Packages Wiki Activity

config: require shared key if using redis backed databroker (#1801)

Browse source
This commit is contained in:
Travis Groth 2021-01-22 16:28:18 -05:00 • committed by GitHub
parent d4037f0010
commit f946d940f5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
config/options.go
View file

@ -496,7 +496,7 @@ func (o *Options) Validate() error {
if IsAll(o.Services) {
// mutual auth between services on the same host can be generated at runtime
if o.SharedKey == "" {
if o.SharedKey == "" && o.DataBrokerStorageType == StorageInMemoryName {
o.SharedKey = cryptutil.NewBase64Key()
}
// in all in one mode we are running just over the local socket

6
config/options_test.go
View file

@ -47,6 +47,11 @@ func Test_Validate(t *testing.T) {
badSignoutRedirectURL := testOptions()
badSignoutRedirectURL.SignOutRedirectURLString = "--"
missingSharedSecretWithPersistence := testOptions()
missingSharedSecretWithPersistence.SharedKey = ""
missingSharedSecretWithPersistence.DataBrokerStorageType = StorageRedisName
missingSharedSecretWithPersistence.DataBrokerStorageConnectionString = "redis://somehost:6379"
tests := []struct {
name string
testOpts *Options
@ -60,6 +65,7 @@ func Test_Validate(t *testing.T) {
{"invalid databroker storage type", invalidStorageType, true},
{"missing databroker storage dsn", missingStorageDSN, true},
{"invalid signout redirect url", badSignoutRedirectURL, true},
{"no shared key with databroker persistence", missingSharedSecretWithPersistence, true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {