diff --git a/internal/telemetry/trace/server.go b/internal/telemetry/trace/server.go index 3b3d3de63..b1a844a10 100644 --- a/internal/telemetry/trace/server.go +++ b/internal/telemetry/trace/server.go @@ -45,7 +45,7 @@ func NewServer(ctx context.Context, remoteClient otlptrace.Client) *ExporterServ return ex } -func (srv *ExporterServer) Start(ctx context.Context) { +func (srv *ExporterServer) Start() { lis := bufconn.Listen(4096) go func() { _ = srv.server.Serve(lis) }() cc, err := grpc.NewClient("passthrough://ignore", diff --git a/internal/telemetry/trace/trace.go b/internal/telemetry/trace/trace.go index 57ff364f7..fa9d44f80 100644 --- a/internal/telemetry/trace/trace.go +++ b/internal/telemetry/trace/trace.go @@ -72,7 +72,7 @@ func (op Options) NewContext(ctx context.Context) context.Context { } ctx = context.WithValue(ctx, systemContextKey, sys) sys.exporterServer = NewServer(ctx, remoteClient) - sys.exporterServer.Start(ctx) + sys.exporterServer.Start() return ctx } diff --git a/internal/testenv/selftests/tracing_test.go b/internal/testenv/selftests/tracing_test.go index faf310b72..3ea5cfb26 100644 --- a/internal/testenv/selftests/tracing_test.go +++ b/internal/testenv/selftests/tracing_test.go @@ -81,7 +81,7 @@ func TestOTLPTracing(t *testing.T) { func TestSampling(t *testing.T) { requireOTLPTracesEndpoint(t) env := testenv.New(t, testenv.AddTraceDebugFlags(testenv.StandardTraceDebugFlags)) - env.Add(testenv.ModifierFunc(func(ctx context.Context, cfg *config.Config) { + env.Add(testenv.ModifierFunc(func(_ context.Context, cfg *config.Config) { cfg.Options.TracingSampleRate = 0.5 })) defer env.Stop() diff --git a/internal/testenv/upstreams/http.go b/internal/testenv/upstreams/http.go index 8c79adceb..78652b2d9 100644 --- a/internal/testenv/upstreams/http.go +++ b/internal/testenv/upstreams/http.go @@ -406,8 +406,8 @@ func authenticateFlow(ctx context.Context, client *http.Client, req *http.Reques return res, nil } fs := forms.Parse(res.Body) - io.ReadAll(res.Body) - res.Body.Close() + _, _ = io.ReadAll(res.Body) + _ = res.Body.Close() if len(fs) > 0 { f := fs[0] f.Inputs["email"] = email