From dd62c32739b07e7bc6df83e563e0cbda0e547da1 Mon Sep 17 00:00:00 2001 From: Caleb Doxsey Date: Thu, 10 Apr 2025 09:54:40 -0600 Subject: [PATCH] use response record version --- pkg/storage/querier_caching.go | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/pkg/storage/querier_caching.go b/pkg/storage/querier_caching.go index f05615844..d9f753477 100644 --- a/pkg/storage/querier_caching.go +++ b/pkg/storage/querier_caching.go @@ -37,18 +37,10 @@ func (q *cachingQuerier) Query(ctx context.Context, in *databroker.QueryRequest, return nil, err } - // If a minimum record version hint is sent, check to see if any of the records meets the minimum + // If a minimum record version hint is sent, check to see if the result meets the minimum // record version and if not, invalidate the cache and re-query. - if in.MinimumRecordVersionHint != nil { - found := false - for _, r := range res.GetRecords() { - if r.GetVersion() >= *in.MinimumRecordVersionHint { - found = true - } - } - if !found { - q.InvalidateCache(ctx, in) - } + if in.MinimumRecordVersionHint != nil && res.RecordVersion < *in.MinimumRecordVersionHint { + q.InvalidateCache(ctx, in) res, err = q.query(ctx, in, opts...) if err != nil { return nil, err