authenticate,proxy: add same site lax to cookies (#2159)

This commit is contained in:
Caleb Doxsey 2021-04-30 10:24:47 -06:00 committed by GitHub
parent 699ebf061a
commit d9cc26a2e0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 0 deletions

View file

@ -5,6 +5,7 @@ import (
"crypto/cipher"
"encoding/base64"
"fmt"
"net/http"
"net/url"
"sync/atomic"
@ -117,6 +118,7 @@ func newAuthenticateStateFromConfig(cfg *config.Config) (*authenticateState, err
Secure: cfg.Options.CookieSecure,
HTTPOnly: cfg.Options.CookieHTTPOnly,
Expire: cfg.Options.CookieExpire,
SameSite: http.SameSiteLaxMode,
}
}, state.sharedEncoder)
if err != nil {

View file

@ -42,6 +42,7 @@ type Options struct {
Expire time.Duration
HTTPOnly bool
Secure bool
SameSite http.SameSite
}
// A GetOptionsFunc is a getter for cookie options.
@ -92,6 +93,7 @@ func (cs *Store) makeCookie(value string) *http.Cookie {
HttpOnly: opts.HTTPOnly,
Secure: opts.Secure,
Expires: timeNow().Add(opts.Expire),
SameSite: opts.SameSite,
}
}

View file

@ -3,6 +3,7 @@ package proxy
import (
"crypto/cipher"
"encoding/base64"
"net/http"
"net/url"
"sync/atomic"
"time"
@ -85,6 +86,7 @@ func newProxyStateFromConfig(cfg *config.Config) (*proxyState, error) {
Secure: cfg.Options.CookieSecure,
HTTPOnly: cfg.Options.CookieHTTPOnly,
Expire: cfg.Options.CookieExpire,
SameSite: http.SameSiteLaxMode,
}
}, state.encoder)
if err != nil {