3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-08-02 16:30:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

ppl: fix empty/no-op allow block added in some cases to converted PPL policies (#5289)

Browse source 
Fix empty/no-op allow block added in some cases to converted PPL policies
This commit is contained in:
Joe Kralicky 2024-09-16 18:52:54 -04:00 • committed by GitHub
parent 6171c09596
commit d06a101f79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 76 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

70
config/policy_ppl_test.go
View file

@ -533,3 +533,73 @@ else := value if {
}
`, str)
}
func TestPolicy_ToPPL_Embedded(t *testing.T) {
policy := Policy{
Policy: &PPLPolicy{
Policy: &parser.Policy{
Rules: []parser.Rule{
{
Action: parser.ActionAllow,
Or: []parser.Criterion{
{
Name: "foo",
Data: parser.Number("5"),
},
},
},
},
},
},
}
assert.Equal(t, policy.Policy.Policy, policy.ToPPL())
policy2 := Policy{
AllowedUsers: []string{"test"},
Policy: &PPLPolicy{
Policy: &parser.Policy{
Rules: []parser.Rule{
{
Action: parser.ActionAllow,
Or: []parser.Criterion{
{
Name: "foo",
Data: parser.Number("5"),
},
},
},
},
},
},
}
assert.Equal(t, &parser.Policy{
Rules: []parser.Rule{
{
Action: parser.ActionAllow,
Or: []parser.Criterion{
{
Name: "user",
Data: parser.Object{
"is": parser.String("test"),
},
},
{
Name: "email",
Data: parser.Object{
"is": parser.String("test"),
},
},
},
},
{
Action: parser.ActionAllow,
Or: []parser.Criterion{
{
Name: "foo",
Data: parser.Number("5"),
},
},
},
},
}, policy2.ToPPL())
}