From c96ff595e524908ba1d0cadd105a2ee13661828d Mon Sep 17 00:00:00 2001 From: contrun Date: Thu, 1 Apr 2021 01:21:16 +0800 Subject: [PATCH] fix not obtaining correct gitlab url because of empty string (#2044) --- internal/directory/provider.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/directory/provider.go b/internal/directory/provider.go index 11b5dab26..7cd77b801 100644 --- a/internal/directory/provider.go +++ b/internal/directory/provider.go @@ -59,7 +59,11 @@ func GetProvider(options Options) (provider Provider) { globalProvider.options = options }() - providerURL, _ := url.Parse(options.ProviderURL) + var providerURL *url.URL + // url.Parse will succeed even if we pass an empty string + if options.ProviderURL != "" { + providerURL, _ = url.Parse(options.ProviderURL) + } switch options.Provider { case auth0.Name: serviceAccount, err := auth0.ParseServiceAccount(options)