config: only validate redirect response code when non-nil (#5358)

* config: only validate redirect response code when non-nil

* update unit tests

---------

Co-authored-by: Kenneth Jenkins <51246568+kenjenkins@users.noreply.github.com>
This commit is contained in:
Joe Kralicky 2024-11-05 15:57:59 -05:00 committed by GitHub
parent 526e2a58d6
commit c8b6b8f1a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 30 additions and 30 deletions

View file

@ -233,12 +233,10 @@ func (r *PolicyRedirect) validate() error {
// GetEnvoyResponseCode returns the ResponseCode as the corresponding Envoy enum value.
func (r *PolicyRedirect) GetEnvoyResponseCode() (envoy_config_route_v3.RedirectAction_RedirectResponseCode, error) {
var code int32
if r != nil && r.ResponseCode != nil {
code = *r.ResponseCode
if r == nil || r.ResponseCode == nil {
return envoy_config_route_v3.RedirectAction_RedirectResponseCode(0), nil
}
switch code {
switch code := *r.ResponseCode; code {
case http.StatusMovedPermanently:
return envoy_config_route_v3.RedirectAction_MOVED_PERMANENTLY, nil
case http.StatusFound: