controlplane: only enable STATIC dns when all adresses are IP addresses (#1822)

This commit is contained in:
Caleb Doxsey 2021-01-25 15:49:58 -07:00 committed by GitHub
parent 979e8f9cec
commit bcc8c17855
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 7 deletions

View file

@ -292,13 +292,13 @@ func buildCluster(
}
// for IPs we use a static discovery type, otherwise we use DNS
isIP := false
allIP := true
for _, lbe := range lbEndpoints {
if net.ParseIP(urlutil.StripPort(lbe.GetEndpoint().GetAddress().GetSocketAddress().GetAddress())) != nil {
isIP = true
if net.ParseIP(urlutil.StripPort(lbe.GetEndpoint().GetAddress().GetSocketAddress().GetAddress())) == nil {
allIP = false
}
}
if isIP {
if allIP {
cluster.ClusterDiscoveryType = &envoy_config_cluster_v3.Cluster_Type{Type: envoy_config_cluster_v3.Cluster_STATIC}
} else {
cluster.ClusterDiscoveryType = &envoy_config_cluster_v3.Cluster_Type{Type: envoy_config_cluster_v3.Cluster_STRICT_DNS}