3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-06-04 03:42:49 +02:00
Code Issues Projects Releases Packages Wiki Activity

pkg/storage: change backend interface to return error (#1131)

Browse source 
Since when storage backend like redis can be fault in many cases, the
interface should return error for the caller to handle.
This commit is contained in:
Cuong Manh Le 2020-07-24 09:02:37 +07:00 • committed by GitHub
parent 90d95b8c10
commit aedfbc4c71
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 108 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

15
pkg/storage/inmemory/inmemory.go
View file

@ -3,6 +3,7 @@ package inmemory
import (
"context"
"errors"
"fmt"
"sync"
"sync/atomic"
@ -88,26 +89,26 @@ func (db *DB) Delete(_ context.Context, id string) error {
}
// Get gets a record from the db.
func (db *DB) Get(_ context.Context, id string) *databroker.Record {
func (db *DB) Get(_ context.Context, id string) (*databroker.Record, error) {
record, ok := db.byID.Get(byIDRecord{Record: &databroker.Record{Id: id}}).(byIDRecord)
if !ok {
return nil
return nil, errors.New("not found")
}
return record.Record
return record.Record, nil
}
// GetAll gets all the records in the db.
func (db *DB) GetAll(_ context.Context) []*databroker.Record {
func (db *DB) GetAll(_ context.Context) ([]*databroker.Record, error) {
var records []*databroker.Record
db.byID.Ascend(func(item btree.Item) bool {
records = append(records, item.(byIDRecord).Record)
return true
})
return records
return records, nil
}
// List lists all the changes since the given version.
func (db *DB) List(_ context.Context, sinceVersion string) []*databroker.Record {
func (db *DB) List(_ context.Context, sinceVersion string) ([]*databroker.Record, error) {
var records []*databroker.Record
db.byVersion.AscendGreaterOrEqual(byVersionRecord{Record: &databroker.Record{Version: sinceVersion}}, func(i btree.Item) bool {
record := i.(byVersionRecord)
@ -116,7 +117,7 @@ func (db *DB) List(_ context.Context, sinceVersion string) []*databroker.Record
}
return true
})
return records
return records, nil
}
// Put replaces or inserts a record in the db.