From a555e5fcc346728c5309ae63242aaa510b16bea3 Mon Sep 17 00:00:00 2001 From: Travis Groth Date: Tue, 4 Aug 2020 08:36:14 -0400 Subject: [PATCH] cmd/pomerium-cli: do not require terminal with cached creds (#1196) --- cmd/pomerium-cli/kubernetes.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cmd/pomerium-cli/kubernetes.go b/cmd/pomerium-cli/kubernetes.go index 4ac5fdace..aa90bd70c 100644 --- a/cmd/pomerium-cli/kubernetes.go +++ b/cmd/pomerium-cli/kubernetes.go @@ -47,10 +47,6 @@ var kubernetesCmd = &cobra.Command{ var kubernetesExecCredentialCmd = &cobra.Command{ Use: "exec-credential", RunE: func(cmd *cobra.Command, args []string) error { - if !terminal.IsTerminal(int(os.Stdin.Fd())) { - return fmt.Errorf("only interactive sessions are supported") - } - if len(args) < 1 { return fmt.Errorf("server url is required") } @@ -66,6 +62,11 @@ var kubernetesExecCredentialCmd = &cobra.Command{ return nil } + // require interactive session to handle login + if !terminal.IsTerminal(int(os.Stdin.Fd())) { + return fmt.Errorf("only interactive sessions are supported") + } + li, err := net.Listen("tcp", "127.0.0.1:0") if err != nil { fatalf("failed to start listener: %v", err)