core/ci: update linting (#4844)

* core/ci: update linting

* re-add exportloopref

* re-add gocheckcompilerdirectives

* re-add stylecheck

* re-add usestdlibvars

* upgrade lint

---------

Co-authored-by: Denis Mishin <dmishin@pomerium.com>
This commit is contained in:
Caleb Doxsey 2023-12-14 10:07:54 -07:00 committed by GitHub
parent b66634d1e6
commit a2fd95aae6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
30 changed files with 132 additions and 214 deletions

View file

@ -16,7 +16,6 @@ import (
)
func TestReadRecords(t *testing.T) {
dir := t.TempDir()
fd, err := os.CreateTemp(dir, "config")
require.NoError(t, err)
@ -34,7 +33,7 @@ func TestReadRecords(t *testing.T) {
}
func writeSampleRecords(dst io.Writer) error {
var marshalOpts = protodelim.MarshalOptions{
marshalOpts := protodelim.MarshalOptions{
MarshalOptions: proto.MarshalOptions{
AllowPartial: false,
Deterministic: true,

View file

@ -73,7 +73,6 @@ func TestQueueMarkForSyncLater(t *testing.T) {
assert.Equal(t, "bundle1", id4)
assert.False(t, ok5, "Expected no more bundles to sync")
assert.Empty(t, id5)
}
func TestQueueGetNextBundleToSync(t *testing.T) {

View file

@ -37,10 +37,8 @@ const (
BundleCacheEntryRecordType = "pomerium.io/BundleCacheEntry"
)
var (
// ErrBundleCacheEntryNotFound is returned when a bundle cache entry is not found
ErrBundleCacheEntryNotFound = errors.New("bundle cache entry not found")
)
// ErrBundleCacheEntryNotFound is returned when a bundle cache entry is not found
var ErrBundleCacheEntryNotFound = errors.New("bundle cache entry not found")
// GetBundleCacheEntry gets a bundle cache entry from the databroker
func (c *service) GetBundleCacheEntry(ctx context.Context, id string) (*BundleCacheEntry, error) {