3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-04-28 18:06:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

add tests

Browse source
This commit is contained in:
Denis Mishin 2025-04-24 13:47:46 -04:00
parent 86d4a39126
commit 825e413def
3 changed files with 37 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/mcp/handler_authorization.go
View file

@ -41,7 +41,7 @@ func (srv *Handler) Authorize(w http.ResponseWriter, r *http.Request) {
return
}
client, err := srv.storage.GetClientByID(ctx, v.ClientId)
client, err := srv.storage.GetClient(ctx, v.ClientId)
if err != nil && status.Code(err) == codes.NotFound {
log.Ctx(ctx).Error().Err(err).Str("id", v.ClientId).Msg("client id not found")
oauth21.ErrorResponse(w, http.StatusUnauthorized, oauth21.InvalidClient)

23
internal/mcp/storage.go
View file

@ -46,7 +46,7 @@ func (storage *Storage) RegisterClient(
return id, nil
}
func (storage *Storage) GetClientByID(
func (storage *Storage) GetClient(
ctx context.Context,
id string,
) (*rfc7591v1.ClientMetadata, error) {
@ -85,3 +85,24 @@ func (storage *Storage) CreateAuthorizationRequest(
}
return id, nil
}
func (storage *Storage) GetAuthorizationRequest(
ctx context.Context,
id string,
) (*oauth21proto.AuthorizationRequest, error) {
v := new(oauth21proto.AuthorizationRequest)
rec, err := storage.client.Get(ctx, &databroker.GetRequest{
Type: protoutil.GetTypeURL(v),
Id: id,
})
if err != nil {
return nil, fmt.Errorf("failed to get authorization request by ID: %w", err)
}
err = anypb.UnmarshalTo(rec.Record.Data, v, proto.UnmarshalOptions{})
if err != nil {
return nil, fmt.Errorf("failed to unmarshal authorization request: %w", err)
}
return v, nil
}

16
internal/mcp/storage_test.go
View file

@ -14,6 +14,7 @@ import (
"github.com/pomerium/pomerium/internal/databroker"
"github.com/pomerium/pomerium/internal/mcp"
oauth21proto "github.com/pomerium/pomerium/internal/oauth21/gen"
rfc7591v1 "github.com/pomerium/pomerium/internal/rfc7591"
"github.com/pomerium/pomerium/internal/testutil"
databroker_grpc "github.com/pomerium/pomerium/pkg/grpc/databroker"
@ -50,15 +51,26 @@ func TestStorage(t *testing.T) {
require.NoError(t, err)
client := databroker_grpc.NewDataBrokerServiceClient(conn)
storage := mcp.NewStorage(client)
t.Run("client registration", func(t *testing.T) {
storage := mcp.NewStorage(client)
t.Parallel()
id, err := storage.RegisterClient(ctx, &rfc7591v1.ClientMetadata{})
require.NoError(t, err)
require.NotEmpty(t, id)
_, err = storage.GetClientByID(ctx, id)
_, err = storage.GetClient(ctx, id)
require.NoError(t, err)
})
t.Run("authorization request", func(t *testing.T) {
t.Parallel()
id, err := storage.CreateAuthorizationRequest(ctx, &oauth21proto.AuthorizationRequest{})
require.NoError(t, err)
_, err = storage.GetAuthorizationRequest(ctx, id)
require.NoError(t, err)
})
}