3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-06-22 04:28:25 +02:00
Code Issues Projects Releases Packages Wiki Activity

core/authz: remove unused mutex

Browse source
This commit is contained in:
Denis Mishin 2025-01-22 15:31:07 -05:00
parent 6e1fabec0b
commit 6de80e6636
2 changed files with 0 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
authorize/authorize.go
View file

@ -6,7 +6,6 @@ import (
"context" "context"
"fmt" "fmt"
"slices" "slices"
"sync"
"time" "time"
"github.com/rs/zerolog" "github.com/rs/zerolog"
@ -35,11 +34,6 @@ type Authorize struct {
globalCache storage.Cache globalCache storage.Cache
groupsCacheWarmer *cacheWarmer groupsCacheWarmer *cacheWarmer
// The stateLock prevents updating the evaluator store simultaneously with an evaluation.
// This should provide a consistent view of the data at a given server/record version and
// avoid partial updates.
stateLock sync.RWMutex
tracerProvider oteltrace.TracerProvider tracerProvider oteltrace.TracerProvider
tracer oteltrace.Tracer tracer oteltrace.Tracer
} }

3
authorize/grpc.go
View file

@ -69,10 +69,7 @@ func (a *Authorize) Check(ctx context.Context, in *envoy_service_auth_v3.CheckRe
return nil, err return nil, err
} }
// take the state lock here so we don't update while evaluating
a.stateLock.RLock()
res, err := state.evaluator.Evaluate(ctx, req) res, err := state.evaluator.Evaluate(ctx, req)
a.stateLock.RUnlock()
if err != nil { if err != nil {
log.Ctx(ctx).Error().Err(err).Str("request-id", requestID).Msg("error during OPA evaluation") log.Ctx(ctx).Error().Err(err).Str("request-id", requestID).Msg("error during OPA evaluation")
return nil, err return nil, err