3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-07-28 14:08:43 +02:00
Code Issues Projects Releases Packages Wiki Activity

config: set default tracing sample rate to 1.0 (#5422)

Browse source 
The previous default sample rate of 0.0001 is very low, so traces are
unlikely to be visible after enabling them until many thousands of
requests have been sent. This could be confusing to users.
This commit is contained in:
Joe Kralicky 2025-01-14 13:50:22 -05:00 • committed by GitHub
parent c571769adc
commit 6502d68162
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 25 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

16
config/trace_test.go
View file

@ -25,13 +25,13 @@ func Test_NewTracingOptions(t *testing.T) {
{
"datadog_good",
&Options{TracingProvider: "datadog"},
&TracingOptions{Provider: "datadog", Service: "pomerium"},
&TracingOptions{Provider: "datadog", Service: "pomerium", SampleRate: 1},
false,
},
{
"jaeger_good",
&Options{TracingProvider: "jaeger", TracingJaegerAgentEndpoint: "foo", TracingJaegerCollectorEndpoint: "http://foo", Services: ServiceAll},
&TracingOptions{Provider: "jaeger", JaegerAgentEndpoint: "foo", JaegerCollectorEndpoint: &url.URL{Scheme: "http", Host: "foo"}, Service: "pomerium"},
&TracingOptions{Provider: "jaeger", JaegerAgentEndpoint: "foo", JaegerCollectorEndpoint: &url.URL{Scheme: "http", Host: "foo"}, Service: "pomerium", SampleRate: 1},
false,
},
{
@ -43,7 +43,7 @@ func Test_NewTracingOptions(t *testing.T) {
{
"zipkin_good",
&Options{TracingProvider: "zipkin", ZipkinEndpoint: "https://foo/api/v1/spans", Services: ServiceAuthorize},
&TracingOptions{Provider: "zipkin", ZipkinEndpoint: &url.URL{Scheme: "https", Host: "foo", Path: "/api/v1/spans"}, Service: "pomerium-authorize"},
&TracingOptions{Provider: "zipkin", ZipkinEndpoint: &url.URL{Scheme: "https", Host: "foo", Path: "/api/v1/spans"}, Service: "pomerium-authorize", SampleRate: 1},
false,
},
{
@ -118,9 +118,8 @@ func TestTraceManager(t *testing.T) {
defer srv2.Close()
src := NewStaticSource(&Config{Options: &Options{
TracingProvider: "zipkin",
ZipkinEndpoint: srv1.URL,
TracingSampleRate: 1,
TracingProvider: "zipkin",
ZipkinEndpoint: srv1.URL,
}})
_ = NewTraceManager(ctx, src)
@ -129,9 +128,8 @@ func TestTraceManager(t *testing.T) {
span.End()
src.SetConfig(ctx, &Config{Options: &Options{
TracingProvider: "zipkin",
ZipkinEndpoint: srv2.URL,
TracingSampleRate: 1,
TracingProvider: "zipkin",
ZipkinEndpoint: srv2.URL,
}})
_, span = trace.StartSpan(ctx, "Example")