Improve test coverage. (#8)

* Improve test coverage.
* Remove unused http status code argument from SignInPageMethod.
* Removed log package in internal packages.
* Add test to check https scheme is used for authorization url.
* Add unit tests for global logging package.

authenticate/handlers_test.go

@@ -0,0 +1,98 @@
+package authenticate
+
+import (
+	"bytes"
+	"fmt"
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"testing"
+
+	"github.com/pomerium/pomerium/authenticate/providers"
+	"github.com/pomerium/pomerium/internal/templates"
+)
+
+func testAuthenticator() *Authenticator {
+	var auth Authenticator
+	auth.RedirectURL, _ = url.Parse("https://auth.example.com/oauth/callback")
+	auth.SharedKey = "IzY7MOZwzfOkmELXgozHDKTxoT3nOYhwkcmUVINsRww="
+	auth.AllowedDomains = []string{"*"}
+	auth.ProxyRootDomains = []string{"example.com"}
+	auth.templates = templates.New()
+	auth.provider = providers.NewTestProvider(auth.RedirectURL)
+	return &auth
+}
+
+func TestAuthenticator_PingPage(t *testing.T) {
+	auth := testAuthenticator()
+	req, err := http.NewRequest("GET", "/ping", nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+	rr := httptest.NewRecorder()
+	handler := http.HandlerFunc(auth.PingPage)
+	handler.ServeHTTP(rr, req)
+	if status := rr.Code; status != http.StatusOK {
+		t.Errorf("handler returned wrong status code: got %v want %v", status, http.StatusOK)
+	}
+	expected := "OK"
+	if rr.Body.String() != expected {
+		t.Errorf("handler returned wrong body: got %v want %v", rr.Body.String(), expected)
+	}
+}
+
+func TestAuthenticator_RobotsTxt(t *testing.T) {
+	auth := testAuthenticator()
+	req, err := http.NewRequest("GET", "/robots.txt", nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+	rr := httptest.NewRecorder()
+	handler := http.HandlerFunc(auth.RobotsTxt)
+	handler.ServeHTTP(rr, req)
+	if status := rr.Code; status != http.StatusOK {
+		t.Errorf("handler returned wrong status code: got %v want %v", status, http.StatusOK)
+	}
+	expected := fmt.Sprintf("User-agent: *\nDisallow: /")
+	if rr.Body.String() != expected {
+		t.Errorf("handler returned wrong body: got %v want %v", rr.Body.String(), expected)
+
+	}
+}
+
+func TestAuthenticator_SignInPage(t *testing.T) {
+	auth := testAuthenticator()
+	v := url.Values{}
+	v.Set("request_uri", "this-is-a-test-uri")
+	url := fmt.Sprintf("/signin?%s", v.Encode())
+
+	req, err := http.NewRequest("GET", url, nil)
+
+	if err != nil {
+		t.Fatal(err)
+	}
+	rr := httptest.NewRecorder()
+	handler := http.HandlerFunc(auth.SignInPage)
+	handler.ServeHTTP(rr, req)
+	if status := rr.Code; status != http.StatusOK {
+		t.Errorf("handler returned wrong status code: got %v want %v", status, http.StatusOK)
+	}
+	body := []byte(rr.Body.String())
+
+	tests := []struct {
+		name  string
+		value string
+		want  bool
+	}{
+		{"provider name", auth.provider.Data().ProviderName, true},
+		{"destination url", v.Encode(), true},
+		{"shouldn't be found", "this string should not be in the body", false},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := bytes.Contains(body, []byte(tt.value)); got != tt.want {
+				t.Errorf("handler body missing expected value %v", tt.value)
+			}
+		})
+	}
+}