3pp-mirror/pomerium
1
0
Fork 0
mirror of https://github.com/pomerium/pomerium.git synced 2025-07-07 20:08:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

chore: unnecessary use of fmt.Sprintf (#4349)

Browse source 
Remove fmt.Sprintf() calls where the format string contains no formatting verbs.
This commit is contained in:
guangwu 2023-07-13 00:44:29 +08:00 • committed by GitHub
parent 4444485dfe
commit 4674b98cfb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
authenticate/handlers_test.go
View file

@ -60,7 +60,7 @@ func TestAuthenticate_RobotsTxt(t *testing.T) {
if status := rr.Code; status != http.StatusOK { if status := rr.Code; status != http.StatusOK {
t.Errorf("handler returned wrong status code: got %v want %v", status, http.StatusOK) t.Errorf("handler returned wrong status code: got %v want %v", status, http.StatusOK)
} }
expected := fmt.Sprintf("User-agent: *\nDisallow: /") expected := "User-agent: *\nDisallow: /"
if rr.Body.String() != expected { if rr.Body.String() != expected {
t.Errorf("handler returned wrong body: got %v want %v", rr.Body.String(), expected) t.Errorf("handler returned wrong body: got %v want %v", rr.Body.String(), expected)
} }
@ -78,7 +78,7 @@ func TestAuthenticate_Handler(t *testing.T) {
rr := httptest.NewRecorder() rr := httptest.NewRecorder()
h.ServeHTTP(rr, req) h.ServeHTTP(rr, req)
expected := fmt.Sprintf("User-agent: *\nDisallow: /") expected := "User-agent: *\nDisallow: /"
body := rr.Body.String() body := rr.Body.String()
if body != expected { if body != expected {
@ -92,7 +92,7 @@ func TestAuthenticate_Handler(t *testing.T) {
req.Header.Set("Access-Control-Request-Headers", "X-Requested-With") req.Header.Set("Access-Control-Request-Headers", "X-Requested-With")
rr = httptest.NewRecorder() rr = httptest.NewRecorder()
h.ServeHTTP(rr, req) h.ServeHTTP(rr, req)
expected = fmt.Sprintf("User-agent: *\nDisallow: /") expected = "User-agent: *\nDisallow: /"
code := rr.Code code := rr.Code
if code/100 != 2 { if code/100 != 2 {
t.Errorf("bad preflight code %v", code) t.Errorf("bad preflight code %v", code)

4
pkg/cryptutil/hmac_test.go
View file

@ -56,8 +56,8 @@ func TestValidTimestamp(t *testing.T) {
{"good - now + 200ms", fmt.Sprint(time.Now().Add(200 * time.Millisecond).Unix()), false}, {"good - now + 200ms", fmt.Sprint(time.Now().Add(200 * time.Millisecond).Unix()), false},
{"bad - now + 10m", fmt.Sprint(time.Now().Add(10 * time.Minute).Unix()), true}, {"bad - now + 10m", fmt.Sprint(time.Now().Add(10 * time.Minute).Unix()), true},
{"bad - now - 10m", fmt.Sprint(time.Now().Add(-10 * time.Minute).Unix()), true}, {"bad - now - 10m", fmt.Sprint(time.Now().Add(-10 * time.Minute).Unix()), true},
{"malformed - non int", fmt.Sprint("pomerium"), true}, {"malformed - non int", "pomerium", true},
{"malformed - negative number", fmt.Sprint("-1"), true}, {"malformed - negative number", "-1", true},
{"malformed - huge number", fmt.Sprintf("%d", 10*10000000000), true}, {"malformed - huge number", fmt.Sprintf("%d", 10*10000000000), true},
} }
for _, tt := range tests { for _, tt := range tests {