From f65518f865863ccc6fa66ce95374d8f462c7de45 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Wed, 23 Apr 2025 17:22:22 +0200 Subject: [PATCH] :bug: Fix incorrect migration application after binfile import --- backend/src/app/binfile/v3.clj | 10 +++++++++- common/src/app/common/files/migrations.cljc | 2 -- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/backend/src/app/binfile/v3.clj b/backend/src/app/binfile/v3.clj index 07e953d68d..07ba4618dd 100644 --- a/backend/src/app/binfile/v3.clj +++ b/backend/src/app/binfile/v3.clj @@ -15,6 +15,7 @@ [app.common.data.macros :as dm] [app.common.exceptions :as ex] [app.common.features :as cfeat] + [app.common.files.migrations :as-alias fmg] [app.common.json :as json] [app.common.logging :as l] [app.common.schema :as sm] @@ -745,7 +746,14 @@ (assoc :name file-name) (assoc :project-id project-id) (dissoc :options) - (bfc/process-file))] + (bfc/process-file) + + ;; NOTE: this is necessary because when we just + ;; creating a new file from imported artifact, + ;; there are no migrations registered on the + ;; database, so we need to persist all of them, not + ;; only the applied + (vary-meta dissoc ::fmg/migrated))] (bfm/register-pending-migrations! cfg file) diff --git a/common/src/app/common/files/migrations.cljc b/common/src/app/common/files/migrations.cljc index 1c08ad4743..4d9a80e235 100644 --- a/common/src/app/common/files/migrations.cljc +++ b/common/src/app/common/files/migrations.cljc @@ -37,8 +37,6 @@ #?(:cljs (l/set-level! :info)) (declare ^:private available-migrations) -(declare ^:private migration-up-index) -(declare ^:private migration-down-index) (def version cfd/version)