From f5296cafb1c3433589927841fc17c51115404eb0 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Thu, 16 Nov 2023 17:40:09 +0100 Subject: [PATCH] :paperclip: Add rationale comment on dom/get-data helper --- frontend/src/app/util/dom.cljs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/frontend/src/app/util/dom.cljs b/frontend/src/app/util/dom.cljs index 8ce4347ae2..8b04784789 100644 --- a/frontend/src/app/util/dom.cljs +++ b/frontend/src/app/util/dom.cljs @@ -570,11 +570,16 @@ (when (some? node) (= (get-active) node))) -(defn get-data [^js node ^string attr] +(defn get-data + [^js node ^string attr] + ;; NOTE: we use getAttribute instead of .dataset for performance + ;; reasons. The getAttribute is x2 faster than dataset. See more on: + ;; https://www.measurethat.net/Benchmarks/Show/14432/0/getattribute-vs-dataset (when (some? node) (.getAttribute node (dm/str "data-" attr)))) -(defn set-data! [^js node ^string attr value] +(defn set-data! + [^js node ^string attr value] (when (some? node) (.setAttribute node (dm/str "data-" attr) (dm/str value))))