3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-05-17 06:36:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

🐛 Fix problem with dashboard multiple selection (#5836)

Browse source
This commit is contained in:
Alonso Torres 2025-02-12 14:34:05 +01:00 • committed by GitHub
parent 51f924a5e1
commit ceb90cd9e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 28 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

27
frontend/playwright/ui/specs/dashboard.spec.js
View file

@ -84,6 +84,33 @@ test("User has context menu options for edit file", async ({ page }) => {
await expect(dashboardPage.page.getByText("delete")).toBeVisible(); await expect(dashboardPage.page.getByText("delete")).toBeVisible();
}); });
test("Multiple elements in context", async ({ page }) => {
await DashboardPage.mockRPC(
page,
"get-all-projects",
"dashboard/get-all-projects.json",
);
const dashboardPage = new DashboardPage(page);
await dashboardPage.setupDrafts();
await dashboardPage.goToDrafts();
const button = dashboardPage.page.getByRole("button", { name: /New File 1/ });
await button.click();
const button2 = dashboardPage.page.getByRole("button", {
name: /New File 2/,
});
await button2.click({ modifiers: ["Shift"] });
await button.click({ button: "right" });
await expect(button.getByTestId("duplicate-multi")).toBeVisible();
await expect(button.getByTestId("file-move-multi")).toBeVisible();
await expect(button.getByTestId("file-binary-export-multi")).toBeVisible();
await expect(button.getByTestId("file-delete-multi")).toBeVisible();
});
test("User has create file button", async ({ page }) => { test("User has create file button", async ({ page }) => {
const dashboardPage = new DashboardPage(page); const dashboardPage = new DashboardPage(page);
await dashboardPage.setupDrafts(); await dashboardPage.setupDrafts();

2
frontend/src/app/main/ui/dashboard/grid.cljs
View file

@ -333,7 +333,7 @@
on-context-menu on-context-menu
(mf/use-fn (mf/use-fn
(mf/deps is-library-view) (mf/deps on-menu-click is-library-view)
(fn [event] (fn [event]
(dom/stop-propagation event) (dom/stop-propagation event)
(dom/prevent-default event) (dom/prevent-default event)