3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-06-14 05:41:40 +02:00
Code Issues Projects Releases Packages Wiki Activity

🐛 Fix comments positioning on viewer (regression)

Browse source
This commit is contained in:
Andrey Antukh 2022-08-24 10:59:38 +02:00
parent 1e9fb6e391
commit be1c19e718
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
frontend/src/app/main/ui/viewer/comments.cljs
View file

@ -91,7 +91,6 @@
(mf/defc comments-layer (mf/defc comments-layer
[{:keys [zoom file users frame page] :as props}] [{:keys [zoom file users frame page] :as props}]
(prn "comments-layer")
(let [profile (mf/deref refs/profile) (let [profile (mf/deref refs/profile)
local (mf/deref refs/comments-local) local (mf/deref refs/comments-local)
@ -113,12 +112,12 @@
modifier1 (mf/with-memo [frame-corner] modifier1 (mf/with-memo [frame-corner]
(-> (gmt/matrix) (-> (gmt/matrix)
(gmt/translate (gpt/negate frame-corner)))) (gmt/translate (gpt/negate frame-corner))))
modifier2 (mf/with-memo [frame-corner] modifier2 (mf/with-memo [frame-corner]
(-> (gpt/point frame-corner) (-> (gpt/point frame-corner)
(gmt/translate-matrix))) (gmt/translate-matrix)))
threads (mf/with-memo [threads-map positions frame local profile]
threads (mf/with-memo [threads-map positions]
(->> (vals threads-map) (->> (vals threads-map)
(map (partial update-thread-position positions)) (map (partial update-thread-position positions))
(filter #(= (:frame-id %) (:id frame))) (filter #(= (:frame-id %) (:id frame)))
@ -126,7 +125,6 @@
(filter (fn [{:keys [position]}] (filter (fn [{:keys [position]}]
(gsh/has-point? frame position))))) (gsh/has-point? frame position)))))
on-bubble-click on-bubble-click
(mf/use-fn (mf/use-fn
(mf/deps open-thread-id) (mf/deps open-thread-id)
@ -160,9 +158,7 @@
(mf/use-fn (mf/use-fn
(mf/deps frame-id modifier2) (mf/deps frame-id modifier2)
(fn [draft] (fn [draft]
(let [params (-> draft (let [params (assoc draft :frame-id frame-id)]
(update :position gpt/transform modifier2)
(assoc :frame-id frame-id))]
(st/emit! (dcm/create-thread-on-viewer params) (st/emit! (dcm/create-thread-on-viewer params)
(dcm/close-thread)))))] (dcm/close-thread)))))]