♻️ Add minor refactor to file migrations

Relevant changes:

- Add the ability to create migration in both directions, defaulting
  to identity if not provided
- Move the version attribute to file table column for to make it more
  accessible (previously it was on data blob)
- Reduce db update operations on file-update rpc method

backend/src/app/rpc/commands/files.clj

@@ -71,19 +71,14 @@
       data     (assoc :data (blob/decode data)))))
 
 (defn check-version!
-  [{:keys [data] :as file}]
-  (dm/assert!
-   "expect data to be decoded"
-   (map? data))
-
-  (let [version (:version data 0)]
+  [file]
+  (let [version (:version file)]
     (when (> version fmg/version)
       (ex/raise :type :restriction
                 :code :file-version-not-supported
                 :hint "file version is greated that the maximum"
                 :file-version version
                 :max-version fmg/version))
-
     file))
 
 ;; --- FILE PERMISSIONS
@@ -252,6 +247,7 @@
 
       (db/update! conn :file
                   {:data (blob/encode (:data file))
+                   :version (:version file)
                    :features (db/create-array conn "text" (:features file))}
                   {:id id})
 

backend/src/app/rpc/commands/files_create.clj

@@ -9,6 +9,7 @@
    [app.common.data :as d]
    [app.common.data.macros :as dm]
    [app.common.features :as cfeat]
+   [app.common.files.defaults :refer [version]]
    [app.common.schema :as sm]
    [app.common.types.file :as ctf]
    [app.common.uuid :as uuid]
@@ -61,6 +62,7 @@
                     :name name
                     :revn revn
                     :is-shared is-shared
+                    :version version
                     :data data
                     :features features
                     :ignore-sync-until ignore-sync-until

backend/src/app/rpc/commands/files_update.clj

@@ -183,8 +183,8 @@
                                                (l/trace :hint "update-file" :time (dt/format-duration elapsed))))))))))
 
 (defn update-file
-  [{:keys [::db/conn ::mtx/metrics] :as cfg}
-   {:keys [id file features changes changes-with-metadata] :as params}]
+  [{:keys [::mtx/metrics] :as cfg}
+   {:keys [file features changes changes-with-metadata] :as params}]
   (let [features  (-> features
                       (set/difference cfeat/frontend-only-features)
                       (set/union (:features file)))
@@ -207,12 +207,6 @@
 
     (mtx/run! metrics {:id :update-file-changes :inc (count changes)})
 
-    (when (not= features (:features file))
-      (let [features (db/create-array conn "text" features)]
-        (db/update! conn :file
-                    {:features features}
-                    {:id id})))
-
     (binding [cfeat/*current*  features
               cfeat/*previous* (:features file)]
       (let [file   (assoc file :features features)
@@ -234,7 +228,8 @@
    {:keys [profile-id file changes session-id ::created-at skip-validate] :as params}]
   (let [;; Process the file data on separated thread for avoid to do
         ;; the CPU intensive operation on vthread.
-        file (px/invoke! executor (partial update-file-data cfg file changes skip-validate))]
+        file     (px/invoke! executor (partial update-file-data cfg file changes skip-validate))
+        features (db/create-array conn "text" (:features file))]
 
     (db/insert! conn :file-change
                 {:id (uuid/next)
@@ -252,6 +247,8 @@
     (db/update! conn :file
                 {:revn (:revn file)
                  :data (:data file)
+                 :version (:version file)
+                 :features features
                  :data-backend nil
                  :modified-at created-at
                  :has-media-trimmed false}