3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-07-30 00:37:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

✨ Normalize permission checks.

Browse source
This commit is contained in:
Andrey Antukh 2021-01-21 11:19:03 +01:00 • committed by Alonso Torres
parent 66fe0048a5
commit b4ba9d4375
4 changed files with 72 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

29
backend/src/app/rpc/queries/projects.clj
View file

@ -12,6 +12,7 @@
[app.common.exceptions :as ex]
[app.common.spec :as us]
[app.db :as db]
[app.rpc.permissions :as perms]
[app.rpc.queries.teams :as teams]
[app.util.services :as sv]
[clojure.spec.alpha :as s]))
@ -34,29 +35,17 @@
where ppr.project_id = ?
and ppr.profile_id = ?")
(defn check-edition-permissions!
(defn- retrieve-project-permissions
[conn profile-id project-id]
(let [rows (db/exec! conn [sql:project-permissions
project-id profile-id
project-id profile-id])]
(when (empty? rows)
(ex/raise :type :not-found))
(when-not (or (some :can-edit rows)
(some :is-admin rows)
(some :is-owner rows))
(ex/raise :type :authorization
:code :not-authorized))))
(db/exec! conn [sql:project-permissions
project-id profile-id
project-id profile-id]))
(defn check-read-permissions!
[conn profile-id project-id]
(let [rows (db/exec! conn [sql:project-permissions
project-id profile-id
project-id profile-id])]
(when-not (seq rows)
(ex/raise :type :authorization
:code :not-authorized))))
(def check-edition-permissions!
(perms/make-edition-check-fn retrieve-project-permissions))
(def check-read-permissions!
(perms/make-read-check-fn retrieve-project-permissions))
;; --- Query: Projects