♻️ Refactor storage and assets related modules

- improve internal error handling
- add more specs and more asserts

backend/src/app/tasks/tasks_gc.clj

@@ -8,35 +8,33 @@
   "A maintenance task that performs a cleanup of already executed tasks
   from the database table."
   (:require
-   [app.common.data :as d]
    [app.common.logging :as l]
    [app.config :as cf]
    [app.db :as db]
-   [app.util.time :as dt]
    [clojure.spec.alpha :as s]
    [integrant.core :as ig]))
 
-(declare sql:delete-completed-tasks)
-
-(s/def ::min-age ::dt/duration)
+(def ^:private
+  sql:delete-completed-tasks
+  "delete from task_completed
+    where scheduled_at < now() - ?::interval")
 
 (defmethod ig/pre-init-spec ::handler [_]
-  (s/keys :req-un [::db/pool]
-          :opt-un [::min-age]))
+  (s/keys :req [::db/pool]))
 
 (defmethod ig/prep-key ::handler
   [_ cfg]
-  (merge {:min-age cf/deletion-delay}
-         (d/without-nils cfg)))
+  (assoc cfg ::min-age cf/deletion-delay))
 
 (defmethod ig/init-key ::handler
-  [_ {:keys [pool] :as cfg}]
+  [_ {:keys [::db/pool ::min-age] :as cfg}]
   (fn [params]
-    (let [min-age (or (:min-age params) (:min-age cfg))]
+    (let [min-age (or (:min-age params) min-age)]
       (db/with-atomic [conn pool]
         (let [interval (db/interval min-age)
               result   (db/exec-one! conn [sql:delete-completed-tasks interval])
-              result   (:next.jdbc/update-count result)]
+              result   (db/get-update-count result)]
+
           (l/debug :hint "task finished" :total result)
 
           (when (:rollback? params)
@@ -44,7 +42,3 @@
 
           result)))))
 
-(def ^:private
-  sql:delete-completed-tasks
-  "delete from task_completed
-    where scheduled_at < now() - ?::interval")