3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-06-06 04:51:38 +02:00
Code Issues Projects Releases Packages Wiki Activity

🐛 Fix problem with thumbnails size

Browse source
This commit is contained in:
alonso.torres 2024-01-19 15:51:58 +01:00
parent 02044a8153
commit 97a6095762
1 changed files with 31 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

31
frontend/src/app/main/ui/workspace/shapes/frame.cljs
View file

@ -24,7 +24,9 @@
[app.main.ui.workspace.shapes.frame.dynamic-modifiers :as fdm] [app.main.ui.workspace.shapes.frame.dynamic-modifiers :as fdm]
[app.util.debug :as dbg] [app.util.debug :as dbg]
[app.util.dom :as dom] [app.util.dom :as dom]
[app.util.thumbnails :as th]
[app.util.timers :as tm] [app.util.timers :as tm]
[promesa.core :as p]
[rumext.v2 :as mf])) [rumext.v2 :as mf]))
(defn frame-shape-factory (defn frame-shape-factory
@ -81,6 +83,34 @@
(fdm/use-dynamic-modifiers objects (mf/ref-val node-ref) modifiers) (fdm/use-dynamic-modifiers objects (mf/ref-val node-ref) modifiers)
[:& frame-shape {:shape shape :ref node-ref}])))) [:& frame-shape {:shape shape :ref node-ref}]))))
(defn image-size
[href]
(p/create
(fn [resolve _]
(let [img (js/Image.)
load-fn
(fn []
(let [width (.-naturalWidth img)
height (.-naturalHeight img)]
(resolve {:width width :height height})))]
(set! (.-onload img) load-fn)
(set! (.-src img) href)))))
(defn check-thumbnail-size
[image-node bounds file-id page-id frame-id]
(let [href (dom/get-attribute image-node "href")
width (dm/get-prop bounds :width)
height (dm/get-prop bounds :height)
[fixed-width fixed-height] (th/get-relative-size width height)]
;; Even if looks like we're doing a new request the browser caches the image
;; so really we don't. We need a different API to check the sizes
(-> (image-size href)
(p/then
(fn [{:keys [width height]}]
(when (or (not (mth/close? width fixed-width 2))
(not (mth/close? height fixed-height 2)))
(st/emit! (dwt/request-thumbnail file-id page-id frame-id "frame"))))))))
(defn root-frame-wrapper-factory (defn root-frame-wrapper-factory
[shape-wrapper] [shape-wrapper]
(let [frame-shape (frame-shape-factory shape-wrapper)] (let [frame-shape (frame-shape-factory shape-wrapper)]
@ -125,6 +155,7 @@
task-ref (mf/use-ref nil) task-ref (mf/use-ref nil)
on-load (mf/use-fn (fn [] on-load (mf/use-fn (fn []
(check-thumbnail-size (mf/ref-val imposter-ref) bounds file-id page-id frame-id)
(mf/set-ref-val! tries-ref 0) (mf/set-ref-val! tries-ref 0)
(reset! imposter-loaded true))) (reset! imposter-loaded true)))
on-error (mf/use-fn on-error (mf/use-fn