3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-06-07 01:31:44 +02:00
Code Issues Projects Releases Packages Wiki Activity

🐛 Fix unexpected console errors on removing shape.

Browse source 
Caused because in some instances selected shapes set
will contain an id that is already removed from object.
This is a tipical race condition.
This commit is contained in:
Andrey Antukh 2021-04-13 13:10:51 +02:00
parent 239ec12529
commit 94ccc013d7
4 changed files with 15 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
frontend/src/app/main/ui/measurements.cljs
View file

@ -233,7 +233,8 @@
:stroke-width (/ select-guide-width zoom)
:stroke-dasharray (/ select-guide-dasharray zoom)}}])])
(mf/defc measurement [{:keys [bounds frame selected-shapes hover-shape zoom]}]
(mf/defc measurement
[{:keys [bounds frame selected-shapes hover-shape zoom]}]
(let [selected-ids (into #{} (map :id) selected-shapes)
selected-selrect (gsh/selection-rect selected-shapes)
hover-selrect (:selrect hover-shape)
@ -244,7 +245,7 @@
[:g.measurement-feedback {:pointer-events "none"}
[:& selection-guides {:selrect selected-selrect :bounds bounds :zoom zoom}]
[:& size-display {:selrect selected-selrect :zoom zoom}]
(if (or (not hover-shape) (not hover-selected-shape?))
(when frame
[:g.hover-shapes