🐛 Fix incorrect webhook url validation

This commit is contained in:
Andrey Antukh 2023-03-16 19:42:17 +01:00
parent f18d2ea629
commit 9143639357

View file

@ -48,25 +48,24 @@
(defn- validate-webhook! (defn- validate-webhook!
[cfg whook params] [cfg whook params]
(when (not= (:uri whook) (:uri params)) (when (not= (:uri whook) (:uri params))
(try (let [response (ex/try!
(let [response (http/req! cfg (http/req! cfg
{:method :head {:method :head
:uri (str (:uri params)) :uri (str (:uri params))
:timeout (dt/duration "3s")} :timeout (dt/duration "3s")}
{:sync? true})] {:sync? true}))]
(when-let [hint (webhooks/interpret-response response)] (if (ex/exception? response)
(ex/raise :type :validation (if-let [hint (webhooks/interpret-exception response)]
:code :webhook-validation
:hint hint)))
(catch Throwable cause
(if-let [hint (webhooks/interpret-exception cause)]
(ex/raise :type :validation (ex/raise :type :validation
:code :webhook-validation :code :webhook-validation
:hint hint) :hint hint)
(ex/raise :type :internal (ex/raise :type :internal
:code :webhook-validation :code :webhook-validation
:cause cause)))))) :cause response))
(when-let [hint (webhooks/interpret-response response)]
(ex/raise :type :validation
:code :webhook-validation
:hint hint))))))
(defn- validate-quotes! (defn- validate-quotes!
[{:keys [::db/pool]} {:keys [team-id]}] [{:keys [::db/pool]} {:keys [team-id]}]