🔧 Enable back clippy rules (#6492)

* 🔧 Fix lint script (rust)

* 🔧 Temporarily add clippy rules to ignore so lint script passes

* 💄 Fix clippy rule crate_in_macro_def

* 💄 Fix clippy rule redundant-static-lifetimes

* 💄 Fix clippy rule unnecessary_cast

* 💄 Fix clippy rule nonminimal_bool

* 💄 Fix clippy rule redundant_pattern_matching

* 💄 Fix clippy rule assign_op_pattern

* 💄 Fix clippy rule needless_lifetimes

* 💄 Fix clippy rule for_kv_map

* 💄 Fix clippy rule ptr_arg

* 💄 Fix clippy rule match_like_matches_macro

* 💄 Fix clippy rule macro_metavars_in_unsafe

* 💄 Fix clippy rule map_clone

* 💄 Fix clippy rule wrong_self_convention

* 💄 Fix clippy rule vec_box

* 💄 Fix clippy rule useless_format

* 💄 Fix clippy rule unwrap_or_default

* 💄 Fix clippy rule unused_unit

* 💄 Fix clippy rule unnecessary_to_owned

* 💄 Fix clippy rule too_many_arguments

* 💄 Fix clippy rule slow_vector_initialization

* 💄 Fix clippy rule single_match

* 💄 Fix clippy rule redundant_field_names

* 💄 Fix clippy rule rendudant_closure

* 💄 Fix clippy rule needless_return

* 💄 Fix clippy rule needless_range_loop

* 💄 Fix clippy rule needless_borrows_for_generic_args

* 💄 Fix clippy rule needless-borrow

* 💄 Fix clippy rule missing_transmute_annotations

* 💄 Fix clippy rule map_entry

* 💄 Fix clippy rule manual_map

* 💄 Fix clippy rule len_zero

* 💄 Fix clippy rule from_over_into

* 💄 Fix clippy rule field_reassign_with_default

* 💄 Fix clippy rule enum_variant_names

* 💄 Fix clippy rule derivable_impls

* 💄 Fix clippy rule clone_on_copy

* 💄 Fix clippy rule box_collection

* 🔧 Make lint script also check test config target

* 🔧 Remove cargo-watch as a lib dependency

* 💄 Fix clippy rule for join_bounds

* 🔧 Fix lint script return code

---------

Co-authored-by: alonso.torres <alonso.torres@kaleidos.net>

render-wasm/lint

@@ -10,45 +10,30 @@ fi
 
 . ./_build_env
 
-ALLOWED_RULES="
-        -A clippy::box_collection \
-        -A clippy::clone_on_copy \
-        -A clippy::derivable_impls \
-        -A clippy::enum_variant_names \
-        -A clippy::field_reassign_with_default \
-        -A clippy::from_over_into \
-        -A clippy::len_zero \
-        -A clippy::manual_map \
-        -A clippy::map_entry \
-        -A clippy::missing_safety_doc \
-        -A clippy::missing_transmute_annotations \
-        -A clippy::needless_borrow \
-        -A clippy::needless_borrows_for_generic_args \
-        -A clippy::needless_range_loop \
-        -A clippy::needless_return \
-        -A clippy::redundant_closure \
-        -A clippy::redundant_field_names \
-        -A clippy::single_match \
-        -A clippy::slow_vector_initialization \
-        -A clippy::too_many_arguments \
-        -A clippy::unnecessary_to_owned \
-        -A clippy::unused_unit \
-        -A clippy::unwrap_or_default \
-        -A clippy::useless_format \
-        -A clippy::wrong_self_convention \
-        -D static_mut_refs"
+export CARGO_BUILD_TARGET=${CARGO_BUILD_TARGET:-"wasm32-unknown-emscripten"};
+export SKIA_BINARIES_URL=${SKIA_BINARIES_URL:-"https://github.com/penpot/skia-binaries/releases/download/0.81.0-3/skia-binaries-24dee32a277b6c7b5357-wasm32-unknown-emscripten-gl-svg-textlayout-binary-cache.tar.gz"}
+
+
+ALLOWED_RULES="-D static_mut_refs"
 
 # ./lint --fix
 if [[ "$1" == "--fix" ]]; then
     cargo clippy \
         --fix --allow-dirty \
         --target=wasm32-unknown-emscripten \
+        --all-targets \
         -- -D warnings \
         $ALLOWED_RULES
 else
     cargo clippy \
         --target=wasm32-unknown-emscripten \
+        --all-targets \
         -- -D warnings \
         $ALLOWED_RULES
 fi
-popd
+
+RESULT=$?
+
+popd
+
+exit $RESULT