3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-07-27 15:07:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

✨ Allow variants with no properties

Browse source
This commit is contained in:
Luis de Dios 2025-06-23 13:28:35 +02:00 • committed by Pablo Alba
parent 25ef1800d0
commit 7cd0e28c3b
2 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
common/src/app/common/files/repair.cljc
View file

@ -602,11 +602,6 @@
(log/error :hint "Variant error code, we don't want to auto repair it for now" :code (:code error)) (log/error :hint "Variant error code, we don't want to auto repair it for now" :code (:code error))
file) file)
(defmethod repair-error :variant-no-properties
[_ error file _]
(log/error :hint "Variant error code, we don't want to auto repair it for now" :code (:code error))
file)
(defmethod repair-error :variant-bad-variant-name (defmethod repair-error :variant-bad-variant-name
[_ error file _] [_ error file _]
(log/error :hint "Variant error code, we don't want to auto repair it for now" :code (:code error)) (log/error :hint "Variant error code, we don't want to auto repair it for now" :code (:code error))

7
common/src/app/common/files/validate.cljc
View file

@ -68,7 +68,6 @@
:variant-bad-name :variant-bad-name
:variant-bad-variant-name :variant-bad-variant-name
:variant-component-bad-name :variant-component-bad-name
:variant-no-properties
:variant-component-bad-id}) :variant-component-bad-id})
(def ^:private schema:error (def ^:private schema:error
@ -589,11 +588,7 @@
(when-not (ctk/is-variant? main-component) (when-not (ctk/is-variant? main-component)
(report-error :not-a-variant (report-error :not-a-variant
(str/ffmt "Shape % should be a variant" (:id main-component)) (str/ffmt "Shape % should be a variant" (:id main-component))
main-component file component-page)) main-component file component-page))))
(when (< (count (:variant-properties component)) 1)
(report-error :variant-no-properties
(str/ffmt "Component variant % should have properties" (:id main-component))
main-component file nil))))
(defn- check-component (defn- check-component
"Validate semantic coherence of a component. Report all errors found." "Validate semantic coherence of a component. Report all errors found."