3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-05-11 05:16:37 +02:00
Code Issues Projects Releases Packages Wiki Activity

🐛 Fix deleted pages comments shown in right sidebar

Browse source
This commit is contained in:
Alejandro Alonso 2023-08-29 12:35:44 +02:00 • committed by Andrey Antukh
parent 514ba6604b
commit 53d1624f3f
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGES.md
View file

@ -11,6 +11,7 @@
- Fix unexpected output on get-page rpc method when invalid object-id is provided [Github #3546](https://github.com/penpot/penpot/issues/3546) - Fix unexpected output on get-page rpc method when invalid object-id is provided [Github #3546](https://github.com/penpot/penpot/issues/3546)
- Fix Invalid files amount after moving file from Project to Drafts [Taiga #5638](https://tree.taiga.io/project/penpot/us/5638) - Fix Invalid files amount after moving file from Project to Drafts [Taiga #5638](https://tree.taiga.io/project/penpot/us/5638)
- Fix deleted pages comments shown in right sidebar [Taiga #5648](https://tree.taiga.io/project/penpot/us/5648)
## 1.19.1 ## 1.19.1

4
frontend/src/app/main/data/comments.cljs
View file

@ -279,7 +279,9 @@
(assoc-in (conj path :position) (:position comment-thread)) (assoc-in (conj path :position) (:position comment-thread))
(assoc-in (conj path :frame-id) (:frame-id comment-thread)))))) (assoc-in (conj path :frame-id) (:frame-id comment-thread))))))
(fetched [[users comments] state] (fetched [[users comments] state]
(let [state (-> state (let [pages (get-in state [:workspace-data :pages-index])
comments (filter #(some? (get pages (:page-id %))) comments)
state (-> state
(assoc :comment-threads (d/index-by :id comments)) (assoc :comment-threads (d/index-by :id comments))
(update :current-file-comments-users merge (d/index-by :id users)))] (update :current-file-comments-users merge (d/index-by :id users)))]
(reduce set-comment-threds state comments)))] (reduce set-comment-threds state comments)))]