3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-06-09 16:31:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

📎 Add some fixmes for future path changes

Browse source
This commit is contained in:
Andrey Antukh 2024-08-26 15:41:01 +02:00
parent 67cd855e97
commit 2f68310a7c
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
common/src/app/common/geom/shapes/path.cljc
View file

@ -893,6 +893,7 @@
(reduce +) (reduce +)
(not= 0)))) (not= 0))))
;; FIXME: this should be on upc/ namespace
(defn split-line-to (defn split-line-to
"Given a point and a line-to command will create a two new line-to commands "Given a point and a line-to command will create a two new line-to commands
that will split the original line into two given a value between 0-1" that will split the original line into two given a value between 0-1"
@ -901,6 +902,7 @@
sp (gpt/lerp from-p to-p t-val)] sp (gpt/lerp from-p to-p t-val)]
[(upc/make-line-to sp) cmd])) [(upc/make-line-to sp) cmd]))
;; FIXME: this should be on upc/ namespace
(defn split-curve-to (defn split-curve-to
"Given the point and a curve-to command will split the curve into two new "Given the point and a curve-to command will split the curve into two new
curve-to commands given a value between 0-1" curve-to commands given a value between 0-1"

2
frontend/src/app/util/path/tools.cljs
View file

@ -12,6 +12,8 @@
[app.common.svg.path.command :as upc] [app.common.svg.path.command :as upc]
[clojure.set :as set])) [clojure.set :as set]))
;; FIXME: move to common, there are nothing tied to frontend
(defn remove-line-curves (defn remove-line-curves
"Remove all curves that have both handlers in the same position that the "Remove all curves that have both handlers in the same position that the
beginning and end points. This makes them really line-to commands" beginning and end points. This makes them really line-to commands"