🐛 Fix local library being collapsed by default (#5775)

* 🐛 Fix local library being collapsed by default

* ♻️ Move layers tab spec code to its own file

frontend/playwright/ui/specs/assets-tab.spec.js

@@ -0,0 +1,67 @@
+import { test, expect } from "@playwright/test";
+import { WorkspacePage } from "../pages/WorkspacePage";
+
+test.beforeEach(async ({ page }) => {
+  await WorkspacePage.init(page);
+});
+
+test("User adds a library and its automatically selected in the color palette", async ({
+  page,
+}) => {
+  const workspacePage = new WorkspacePage(page);
+  await workspacePage.setupEmptyFile();
+  await workspacePage.mockRPC(
+    "link-file-to-library",
+    "workspace/link-file-to-library.json",
+  );
+  await workspacePage.mockRPC(
+    "unlink-file-from-library",
+    "workspace/unlink-file-from-library.json",
+  );
+  await workspacePage.mockRPC(
+    "get-team-shared-files?team-id=*",
+    "workspace/get-team-shared-libraries-non-empty.json",
+  );
+
+  await workspacePage.goToWorkspace();
+
+  // Add Testing library 1
+  await workspacePage.clickColorPalette();
+  await workspacePage.clickAssets();
+  // Now the get-file call should return a library
+  await workspacePage.mockRPC(/get\-file\?/, "workspace/get-file-library.json");
+  await workspacePage.openLibrariesModal();
+  await workspacePage.clickLibrary("Testing library 1");
+  await workspacePage.closeLibrariesModal();
+
+  await expect(
+    workspacePage.palette.getByRole("button", { name: "test-color-187cd5" }),
+  ).toBeVisible();
+
+  // Remove Testing library 1
+  await workspacePage.openLibrariesModal();
+  await workspacePage.clickLibrary("Testing library 1");
+  await workspacePage.closeLibrariesModal();
+
+  await expect(
+    workspacePage.palette.getByText(
+      "There are no color styles in your library yet",
+    ),
+  ).toBeVisible();
+});
+
+test("BUG 10090 - Local library should be expanded by default", async ({
+  page,
+}) => {
+  const workspacePage = new WorkspacePage(page);
+  await workspacePage.setupEmptyFile(page);
+
+  await workspacePage.goToWorkspace();
+
+  await workspacePage.clickAssets();
+
+  expect(workspacePage.sidebar.getByText("Local library")).toBeVisible();
+  expect(workspacePage.sidebar.getByText("Components")).toBeVisible();
+  expect(workspacePage.sidebar.getByText("Colors")).toBeVisible();
+  expect(workspacePage.sidebar.getByText("Typographies")).toBeVisible();
+});

frontend/playwright/ui/specs/layers-tab.spec.js

@@ -0,0 +1,21 @@
+import { test, expect } from "@playwright/test";
+import { WorkspacePage } from "../pages/WorkspacePage";
+
+test.beforeEach(async ({ page }) => {
+  await WorkspacePage.init(page);
+});
+
+test("BUG 7466 - Layers tab height extends to the bottom when 'Pages' is collapsed", async ({
+  page,
+}) => {
+  const workspace = new WorkspacePage(page);
+  await workspace.setupEmptyFile();
+
+  await workspace.goToWorkspace();
+
+  const { height: heightExpanded } = await workspace.layers.boundingBox();
+  await workspace.togglePages();
+  const { height: heightCollapsed } = await workspace.layers.boundingBox();
+
+  expect(heightExpanded > heightCollapsed);
+});

frontend/playwright/ui/specs/sidebar.spec.js

@@ -1,73 +0,0 @@
-import { test, expect } from "@playwright/test";
-import { WorkspacePage } from "../pages/WorkspacePage";
-
-test.beforeEach(async ({ page }) => {
-  await WorkspacePage.init(page);
-});
-
-test.describe("Layers tab", () => {
-  test("BUG 7466 - Layers tab height extends to the bottom when 'Pages' is collapsed", async ({
-    page,
-  }) => {
-    const workspace = new WorkspacePage(page);
-    await workspace.setupEmptyFile();
-
-    await workspace.goToWorkspace();
-
-    const { height: heightExpanded } = await workspace.layers.boundingBox();
-    await workspace.togglePages();
-    const { height: heightCollapsed } = await workspace.layers.boundingBox();
-
-    expect(heightExpanded > heightCollapsed);
-  });
-});
-
-test.describe("Assets tab", () => {
-  test("User adds a library and its automatically selected in the color palette", async ({
-    page,
-  }) => {
-    const workspacePage = new WorkspacePage(page);
-    await workspacePage.setupEmptyFile();
-    await workspacePage.mockRPC(
-      "link-file-to-library",
-      "workspace/link-file-to-library.json",
-    );
-    await workspacePage.mockRPC(
-      "unlink-file-from-library",
-      "workspace/unlink-file-from-library.json",
-    );
-    await workspacePage.mockRPC(
-      "get-team-shared-files?team-id=*",
-      "workspace/get-team-shared-libraries-non-empty.json",
-    );
-
-    await workspacePage.goToWorkspace();
-
-    // Add Testing library 1
-    await workspacePage.clickColorPalette();
-    await workspacePage.clickAssets();
-    // Now the get-file call should return a library
-    await workspacePage.mockRPC(
-      /get\-file\?/,
-      "workspace/get-file-library.json",
-    );
-    await workspacePage.openLibrariesModal();
-    await workspacePage.clickLibrary("Testing library 1");
-    await workspacePage.closeLibrariesModal();
-
-    await expect(
-      workspacePage.palette.getByRole("button", { name: "test-color-187cd5" }),
-    ).toBeVisible();
-
-    // Remove Testing library 1
-    await workspacePage.openLibrariesModal();
-    await workspacePage.clickLibrary("Testing library 1");
-    await workspacePage.closeLibrariesModal();
-
-    await expect(
-      workspacePage.palette.getByText(
-        "There are no color styles in your library yet",
-      ),
-    ).toBeVisible();
-  });
-});

frontend/src/app/main/ui/workspace/sidebar/assets/file_library.cljs

@@ -320,7 +320,7 @@
          (tr "workspace.assets.not-found")]])]))
 
 (mf/defc file-library*
-  [{:keys [file is-local is-default-open? filters]}]
+  [{:keys [file is-local is-default-open filters]}]
   (let [file-id      (:id file)
         file-name    (:name file)
         page-id      (dm/get-in file [:data :pages 0])
@@ -376,7 +376,7 @@
           ;; if the user has closed it specifically, respect that
           false
           (or force-lib-open?
-              (d/nilv (:library open-status) is-default-open?)))
+              (d/nilv (:library open-status) is-default-open)))
 
         unselect-all
         (mf/use-fn