3pp-mirror/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-07-21 03:37:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

✨ Add more improvements to error reporting

Browse source
This commit is contained in:
Andrey Antukh 2023-08-04 10:45:17 +02:00
parent 2ba7996116
commit 259b05db51
2 changed files with 8 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

5
backend/src/app/loggers/database.clj
View file

@ -47,7 +47,7 @@
(assoc :public-uri (cf/get :public-uri)) (assoc :public-uri (cf/get :public-uri))
(assoc :logger/name logger) (assoc :logger/name logger)
(assoc :logger/level level) (assoc :logger/level level)
(dissoc :request/params))] (dissoc :request/params :value :params :data))]
(merge (merge
{:context (-> (into (sorted-map) context) {:context (-> (into (sorted-map) context)
(pp/pprint-str :width 200 :length 50 :level 10)) (pp/pprint-str :width 200 :length 50 :level 10))
@ -55,7 +55,7 @@
:hint (or (ex-message cause) @message) :hint (or (ex-message cause) @message)
:trace (ex/format-throwable cause :data? false :explain? false :header? false :summary? false)} :trace (ex/format-throwable cause :data? false :explain? false :header? false :summary? false)}
(when-let [params (:request/params context)] (when-let [params (or (:request/params context) (:params context))]
{:params (pp/pprint-str params :width 200)}) {:params (pp/pprint-str params :width 200)})
(when-let [value (:value context)] (when-let [value (:value context)]
@ -67,7 +67,6 @@
(when-let [explain (ex/explain data {:level 10 :length 50})] (when-let [explain (ex/explain data {:level 10 :length 50})]
{:explain explain})))) {:explain explain}))))
(defn error-record? (defn error-record?
[{:keys [::l/level ::l/cause]}] [{:keys [::l/level ::l/cause]}]
(and (= :error level) (and (= :error level)

20
backend/src/app/worker.clj
View file

@ -489,16 +489,8 @@
(l/error :hint "worker: unhandled exception" :cause cause)))))) (l/error :hint "worker: unhandled exception" :cause cause))))))
(defn- get-error-context (defn- get-error-context
[error item] [_ item]
(let [data (ex-data error)] {:params item})
(merge
{:hint (ex-message error)
:spec-problems (some->> data ::s/problems (take 10) seq vec)
:spec-value (some->> data ::s/value)
:data (some-> data (dissoc ::s/problems ::s/value ::s/spec))
:params item}
(when-let [explain (ex/explain data)]
{:spec-explain explain}))))
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; CRON ;; CRON
@ -597,10 +589,10 @@
(catch InterruptedException _ (catch InterruptedException _
(l/debug :hint "cron: task interrupted" :task-id id)) (l/debug :hint "cron: task interrupted" :task-id id))
(catch Throwable cause (catch Throwable cause
(l/error :hint "cron: unhandled exception on running task" (binding [l/*context* (get-error-context cause task)]
::l/context (get-error-context cause task) (l/error :hint "cron: unhandled exception on running task"
:task-id id :task-id id
:cause cause)) :cause cause)))
(finally (finally
(when-not (px/interrupted? :current) (when-not (px/interrupted? :current)
(schedule-cron-task cfg task)))))) (schedule-cron-task cfg task))))))